From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: To: Grant Likely Subject: Re: [PATCH] Globally s/struct irq_host/struct irq_domain/ In-reply-to: <20110121171314.GD7477@angua.secretlab.ca> References: <20110121171314.GD7477@angua.secretlab.ca> Date: Fri, 21 Jan 2011 11:19:10 -0600 From: Jon Loeliger Message-Id: Cc: devicetree-discuss@lists.ozlabs.org, linuxppc-dev@lists.ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , > > For this to make sense, it really needs to also rename irq_host_ops > structure, the IRQ_HOST_MAP* #defines, and the irq_*_host functions. > It also /should/ adjust the users of irq_domain to rename function > local variables and structure members. Otherwise there will be an > even worse mismatch in naming. Happy to do so, but last time we talked about this, we decided not to do *that* aspect of the rename with this patch, and that we'd get to it later with follow on patches once this step was done. Your call; just let me know. jdl From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jon Loeliger Subject: Re: [PATCH] Globally s/struct irq_host/struct irq_domain/ Date: Fri, 21 Jan 2011 11:19:10 -0600 Message-ID: References: <20110121171314.GD7477@angua.secretlab.ca> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-reply-to: <20110121171314.GD7477-MrY2KI0G/OVr83L8+7iqerDks+cytr/Z@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org To: Grant Likely Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org List-Id: devicetree@vger.kernel.org > > For this to make sense, it really needs to also rename irq_host_ops > structure, the IRQ_HOST_MAP* #defines, and the irq_*_host functions. > It also /should/ adjust the users of irq_domain to rename function > local variables and structure members. Otherwise there will be an > even worse mismatch in naming. Happy to do so, but last time we talked about this, we decided not to do *that* aspect of the rename with this patch, and that we'd get to it later with follow on patches once this step was done. Your call; just let me know. jdl