All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jon Loeliger <jdl-CYoMK+44s/E@public.gmane.org>
To: Srinivas KANDAGATLA <srinivas.kandagatla-qxv4g6HH51o@public.gmane.org>
Cc: mmarek-AlSwsSmVLrQ@public.gmane.org,
	devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
	B04825-KZfg59tc24xl57MIdRCFDg@public.gmane.org,
	dwg-8fk3Idey6ehBDgjK7y7TUQ@public.gmane.org
Subject: Re: [PATCH v2 dtc-1.3.0] dtc: Add --strip-disabled option to dtc(v2).
Date: Mon, 20 Aug 2012 08:25:40 -0500	[thread overview]
Message-ID: <E1T3RzA-0002rn-SS@jdl.com> (raw)
In-Reply-To: <1345458247-15701-1-git-send-email-srinivas.kandagatla-qxv4g6HH51o@public.gmane.org>

> From: Srinivas Kandagatla <srinivas.kandagatla-qxv4g6HH51o@public.gmane.org>
> 
> This patch allows dtc to strip out nodes in its output based on status
> property. Now the dtc has additional long option --strip-disabled to
> strip all the nodes which do not have status property set to "okay" or
> "ok". Nodes which do not have status property are not stripped.
> 
> SOCs have lot of device tree infrastructure files which mark the
> device nodes as disabled and the board level device tree enables them if
> required. However while creating device tree blob, the compiler can
> exclude nodes marked as disabled, doing this way will reduce the size
> of device tree blob. The size change will be significant once the SOC
> adds all the possible devices in to the device trees. As there could be
> 100s of Ips on SOCs but the board actually uses may be 20-25 IP's.
> 
> However care has to be taken if your boardloader is is updating status
> property.
> 
> In our case this has reduced the blob size from 29K to 15K.
> 
> Also nodes with status="disabled" is are never probed by dt platform bus
> code.
> 
> Again, this is an optional parameter to dtc, Can be used by people who
> want to strip all the device nodes which do not have status property set
> to "okay" or "ok".

I don't know.  This all strikes me as a means to hack around
our total lack of a properly constructed tree based on real
data and valid node presence.  That is, if we had a better
means of constructing your tree in the first place, it would
not habve 50% overhead of dead nodes.

It should be built in a positive sense, perhaps with includes, or a
better system, and not edited out based on questionable negative data.

This just seems like a fundamentally wrong approach to me.

jdl

  parent reply	other threads:[~2012-08-20 13:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-20 10:24 [PATCH v2 dtc-1.3.0] dtc: Add --strip-disabled option to dtc(v2) Srinivas KANDAGATLA
     [not found] ` <1345458247-15701-1-git-send-email-srinivas.kandagatla-qxv4g6HH51o@public.gmane.org>
2012-08-20 13:25   ` Jon Loeliger [this message]
     [not found]     ` <E1T3RzA-0002rn-SS-CYoMK+44s/E@public.gmane.org>
2012-08-20 15:19       ` Srinivas KANDAGATLA
     [not found]         ` <5032557C.8020507-qxv4g6HH51o@public.gmane.org>
2012-08-20 16:09           ` Timur Tabi
2012-08-21  3:17       ` David Gibson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1T3RzA-0002rn-SS@jdl.com \
    --to=jdl-cyomk+44s/e@public.gmane.org \
    --cc=B04825-KZfg59tc24xl57MIdRCFDg@public.gmane.org \
    --cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
    --cc=dwg-8fk3Idey6ehBDgjK7y7TUQ@public.gmane.org \
    --cc=mmarek-AlSwsSmVLrQ@public.gmane.org \
    --cc=srinivas.kandagatla-qxv4g6HH51o@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.