From: Jon Loeliger <jdl-CYoMK+44s/E@public.gmane.org>
To: David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>
Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH V3] dtc: Add ability to delete nodes and properties
Date: Thu, 06 Sep 2012 07:53:48 -0500 [thread overview]
Message-ID: <E1T9bae-0001JH-EF@jdl.com> (raw)
In-Reply-To: <20120904000539.GH8526-W9XWwYn+TF0XU02nzanrWNbf9cGiqdzd@public.gmane.org>
> On Tue, Aug 07, 2012 at 10:50:15PM -0600, Stephen Warren wrote:
> > From: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> >
> > dtc currently allows the contents of properties to be changed, and the
> > contents of nodes to be added to. There are situations where removing
> > properties or nodes may be useful. This change implements the following
> > syntax to do that:
> >
> > / {
> > /delete-property/ propname;
> > /delete-node/ nodename;
> > };
> >
> > or:
> >
> > /delete-node/ &noderef;
> >
> > Signed-off-by: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
>
> Sorry, I've taken forever to look at this. I've had other things to
> work on, plus I've second guessed myself on this stuff about a million
> times.
>
> I think I finally did pin down the chief thing that was making me
> antsy about the whole thing, which is that it introduces an order
> dependency where none existed before. We already had the order
> dependency between tree fragments in the "stack of overlays" model,
> but we didn't previously have a dependency on the order of
> declarations within one fragment.
>
> With that in mind, there are some details I would like to see cleaned
> up, mostly in the precise semantics of when duplicate names are
> detected. But I'm happy enough to do that cleanup after the main
> patch is merged.
>
> Acked-by: David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>
Applied!
jdl
next prev parent reply other threads:[~2012-09-06 12:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-08 4:50 [PATCH V3] dtc: Add ability to delete nodes and properties Stephen Warren
[not found] ` <1344401415-3214-1-git-send-email-swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-08-22 4:12 ` Stephen Warren
2012-09-04 0:05 ` David Gibson
[not found] ` <20120904000539.GH8526-W9XWwYn+TF0XU02nzanrWNbf9cGiqdzd@public.gmane.org>
2012-09-06 12:53 ` Jon Loeliger [this message]
[not found] ` <E1T9bae-0001JH-EF-CYoMK+44s/E@public.gmane.org>
2012-09-06 15:58 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1T9bae-0001JH-EF@jdl.com \
--to=jdl-cyomk+44s/e@public.gmane.org \
--cc=david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org \
--cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
--cc=swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.