From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jon Loeliger Subject: Re: [PATCH V3] dtc: fix for_each_*() to skip first object if deleted Date: Mon, 08 Oct 2012 09:13:15 -0500 Message-ID: References: <1349452661-14445-1-git-send-email-swarren@wwwdotorg.org> <20121005232948.GW29302@truffula.fritz.box> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-reply-to: <20121005232948.GW29302-W9XWwYn+TF0XU02nzanrWNbf9cGiqdzd@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: David Gibson Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, Stephen Warren List-Id: devicetree@vger.kernel.org > On Fri, Oct 05, 2012 at 09:57:41AM -0600, Stephen Warren wrote: > > From: Stephen Warren > > > > The previous definition of for_each_*() would always include the very > > first object within the list, irrespective of whether it was marked > > deleted, since the deleted flag was not checked on the first object, > > but only on any "next" object. > > > > Fix for_each_*() to check the deleted flag in the loop body every > > iteration to correct this. > > > > Incidentally, this change is why commit 45013d8 dtc: "Add ability to > > delete nodes and properties" only caused two "make checkm" failures; > > only two tests actually use multiple labels on the same property or > > node. With this current change applied, but commit 317a5d9 "dtc: zero > > out new label objects" reverted, "make checkm" fails 29 times; i.e. > > for every test that uses any labels at all. > > > > Signed-off-by: Stephen Warren > > Acked-by: David Gibson Applied. Thanks, jdl