From: Tim Shepard <shep@laptop.org>
To: Bing Zhao <bzhao@marvell.com>
Cc: linux-wireless@vger.kernel.org,
"John W. Linville" <linville@tuxdriver.com>,
Amitkumar Karwar <akarwar@marvell.com>,
Daniel Drake <dsd@laptop.org>, Avinash Patil <patila@marvell.com>,
Nishant Sarmukadam <nishants@marvell.com>,
Frank Huang <frankh@marvell.com>
Subject: Re: [PATCH] mwifiex: add support for SDIO card reset
Date: Fri, 02 Nov 2012 17:46:34 -0400 [thread overview]
Message-ID: <E1TUP4U-0002Fm-00@www.xplot.org> (raw)
In-Reply-To: Your message of Thu, 01 Nov 2012 18:44:14 -0700. <1351820654-24433-1-git-send-email-bzhao@marvell.com>
Bing,
I am trying to figure out if this patch would help in the situation I
told you about in September.
I was doing suspend/resume testing using
rtcwake -s 6 -mmem
in a loop to test the ability of the mwifiex driver to suspend/resume.
I was seeing sporadic failures (wedgeups), and the majority of those
failures I saw printed the printouts in mwifiex_cmd_timeout_func with
cmd = 0xe5 which is CMD_802_11_HS_CFG_ENH. When this happens, two
minutes later I get notified that the rtcwake thread is blocked, like
this:
INFO: task rtcwake:3495 blocked for more than 120 seconds.
I believe the hang happens when mwifiex_sdio_suspend() is called in
the rtcwake thread it winds winds up blocked waiting on a wait queue
in mwifiex_enable_hs() because when the timeout happens it never gets
woken up.
Reading your patch today, I don't see how your patch will add a new
way to get that hung thread unblocked.
(I'm also not sure doing the reset of the card will work properly while
the system is in the middle of trying to suspend, but that's a
different question.)
If I'm missing a clue about this, please let me know.
-Tim Shepard
shep@laptop.org
next prev parent reply other threads:[~2012-11-02 22:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-02 1:44 [PATCH] mwifiex: add support for SDIO card reset Bing Zhao
2012-11-02 21:46 ` Tim Shepard [this message]
2012-11-03 2:00 ` Bing Zhao
2012-11-07 4:35 ` Bing Zhao
2012-11-07 16:33 ` Tim Shepard
2012-11-16 21:32 ` Tim Shepard
2012-11-20 5:17 ` Bing Zhao
2012-11-26 11:50 ` Andrei Emeltchenko
2012-11-27 1:09 ` Bing Zhao
2012-11-27 10:22 ` Andrei Emeltchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1TUP4U-0002Fm-00@www.xplot.org \
--to=shep@laptop.org \
--cc=akarwar@marvell.com \
--cc=bzhao@marvell.com \
--cc=dsd@laptop.org \
--cc=frankh@marvell.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=nishants@marvell.com \
--cc=patila@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.