All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jon Loeliger <jdl@jdl.com>
To: Pantelis Antoniou <panto@antoniou-consulting.com>
Cc: David Gibson <david@gibson.dropbear.id.au>,
	Matt Porter <mporter@ti.com>,
	"devicetree-discuss@lists.ozlabs.org"
	<devicetree-discuss@lists.ozlabs.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Rob Herring <rob.herring@calxeda.com>,
	Russ Dill <Russ.Dill@ti.com>
Subject: Re: Fix test relying in wrong behavior of is_printable
Date: Sun, 06 Jan 2013 16:14:23 -0600	[thread overview]
Message-ID: <E1TryU3-0001K5-Iy@jdl.com> (raw)
In-Reply-To: <5B13DF52-26BE-4BA1-8BD7-25863B04A3B6@antoniou-consulting.com>

> Hi David
> 
> =CE=91=CF=80=CF=8C =CF=84=CE=BF iPhone =CE=BC=CE=BF=CF=85
> 
> 6 =CE=99=CE=B1=CE=BD 2013, 5:58, =CE=BF/=CE=B7 David Gibson <david@gibson.dr=
> opbear.id.au> =CE=AD=CE=B3=CF=81=CE=B1=CF=88=CE=B5:
> 
> > On Fri, Jan 04, 2013 at 09:16:08PM +0200, Pantelis Antoniou wrote:
> >> After fixing the is_printable bug the test suite fails.
> >> Fix it with this patch
> >>=20
> >> Signed-off-by: Pantelis Antoniou <panto@antoniou-consulting.com>
> >=20
> > Rather than just removing the test, it would be better to still run it
> > using an explicit -t bi to force the byte output.
> 
> Perhaps it wasn't exactly clear in the patch. The old test case output is co=
> mmented out but there is test case output for the new patch.=20
> 
> So the test is not removed.=20

Uh, yeah, something needs to be done here still.
(There is a failing test still.)

Could we get a resubmission of the fix, please?

Thanks,
jdl

  reply	other threads:[~2013-01-06 22:14 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-04 19:16 Fix test relying in wrong behavior of is_printable Pantelis Antoniou
     [not found] ` <1357326968-13124-1-git-send-email-panto-wVdstyuyKrO8r51toPun2/C9HSW9iNxf@public.gmane.org>
2013-01-06  3:58   ` David Gibson
2013-01-06  3:58     ` David Gibson
     [not found]     ` <20130106035809.GG4674-W9XWwYn+TF0XU02nzanrWNbf9cGiqdzd@public.gmane.org>
2013-01-06 11:41       ` Pantelis Antoniou
2013-01-06 11:41         ` Pantelis Antoniou
2013-01-06 22:14         ` Jon Loeliger [this message]
2013-01-07  9:55           ` Pantelis Antoniou
2013-01-07 14:30             ` Jon Loeliger
     [not found]         ` <5B13DF52-26BE-4BA1-8BD7-25863B04A3B6-wVdstyuyKrO8r51toPun2/C9HSW9iNxf@public.gmane.org>
2013-01-08  8:37           ` David Gibson
2013-01-08  8:37             ` David Gibson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1TryU3-0001K5-Iy@jdl.com \
    --to=jdl@jdl.com \
    --cc=Russ.Dill@ti.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mporter@ti.com \
    --cc=panto@antoniou-consulting.com \
    --cc=rob.herring@calxeda.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.