From: Albert ARIBAUD <albert.u.boot@aribaud.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] ARM:asm:io.h use static inline
Date: Sat, 5 Jul 2014 11:13:59 +0200 [thread overview]
Message-ID: <E1X3M2j-0005DA-0y@janus> (raw)
In-Reply-To: <1403471439-23370-1-git-send-email-jeroen@myspectrum.nl>
Hi Jeroen,
On Sun, 22 Jun 2014 23:10:39 +0200, Jeroen Hofstee
<jeroen@myspectrum.nl> wrote:
> When compiling u-boot with W=1 the extern inline void for
> read* is likely causing the most noise. gcc / clang will
> warn there is never a actual declaration for these functions.
> Instead of declaring these extern make them static inline so
> it is actually declared.
>
> cc: Albert ARIBAUD <albert.u.boot@aribaud.net>
> Signed-off-by: Jeroen Hofstee <jeroen@myspectrum.nl>
> ---
Ok, so the obvious question: what makes you decide to switch to 'static
inline' rather than provide the extern versions that 'extern static'
calls for?
(see e.g. http://elinux.org/Extern_Vs_Static_Inline for an example
discussion on 'static inline' vs 'extern inline'. Note: this link is not
intended as an expression of my stance on the issue, as I don't have
any.)
Amicalement,
--
Albert.
next prev parent reply other threads:[~2014-07-05 9:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-22 21:10 [U-Boot] [PATCH] ARM:asm:io.h use static inline Jeroen Hofstee
2014-07-05 9:13 ` Albert ARIBAUD [this message]
2014-07-05 11:36 ` Jeroen Hofstee
2014-07-05 13:21 ` Albert ARIBAUD
2014-07-05 13:30 ` Jeroen Hofstee
2014-07-05 14:58 ` Albert ARIBAUD
2014-08-30 15:13 ` [U-Boot] " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1X3M2j-0005DA-0y@janus \
--to=albert.u.boot@aribaud.net \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.