All of lore.kernel.org
 help / color / mirror / Atom feed
From: Albert ARIBAUD <albert.u.boot@aribaud.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] arch/arm: Add individual TLB size support.
Date: Tue, 9 Sep 2014 13:48:43 +0200	[thread overview]
Message-ID: <E1XRJuc-0002eU-70@janus> (raw)
In-Reply-To: <1404710351-37250-1-git-send-email-Li.Xiubo@freescale.com>

Hi Xiubo,

On Mon, 7 Jul 2014 13:19:11 +0800, Xiubo Li <Li.Xiubo@freescale.com>
wrote:

> This adds CONFIG_TLB_SIZE for individual board, whose TLB size maybe
> larger than PGTABLE_SIZE.
> 
> Signed-off-by: Xiubo Li <Li.Xiubo@freescale.com>
> ---
>  arch/arm/lib/board.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/arch/arm/lib/board.c b/arch/arm/lib/board.c
> index dc34190..b7327ce 100644
> --- a/arch/arm/lib/board.c
> +++ b/arch/arm/lib/board.c
> @@ -353,7 +353,11 @@ void board_init_f(ulong bootflag)
>  
>  #if !(defined(CONFIG_SYS_ICACHE_OFF) && defined(CONFIG_SYS_DCACHE_OFF))
>  	/* reserve TLB table */
> +#ifdef CONFIG_TLB_SIZE
> +	gd->arch.tlb_size = CONFIG_TLB_SIZE;
> +#else
>  	gd->arch.tlb_size = PGTABLE_SIZE;
> +#endif
>  	addr -= gd->arch.tlb_size;
>  
>  	/* round down to next 64 kB limit */

There is no code in current mainline which defines CONFIG_TLB_SIZE;
that makes the patch a dead code addition.

Besides, what's the point of this as opposed to, e.g., just defining the
right PGTABLE_SIZE, or renaming PGTABLE_SIZE as CONFIG_TLB_SIZE?

Amicalement,
-- 
Albert.

  reply	other threads:[~2014-09-09 11:48 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-07  5:19 [U-Boot] [PATCH] arch/arm: Add individual TLB size support Xiubo Li
2014-09-09 11:48 ` Albert ARIBAUD [this message]
2014-09-10  3:10   ` Li.Xiubo at freescale.com
2014-09-11 15:55     ` Albert ARIBAUD
2014-09-18  8:37       ` Albert ARIBAUD

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1XRJuc-0002eU-70@janus \
    --to=albert.u.boot@aribaud.net \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.