All of lore.kernel.org
 help / color / mirror / Atom feed
From: Albert ARIBAUD <albert.u.boot@aribaud.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] kconfig: add CONFIG_SUPPORT_TPL
Date: Sat, 11 Oct 2014 10:56:47 +0200	[thread overview]
Message-ID: <E1XcsTo-0007rL-Ob@janus> (raw)
In-Reply-To: <1411636747-10276-3-git-send-email-yamada.m@jp.panasonic.com>

Hi Masahiro,

On Thu, 25 Sep 2014 18:19:07 +0900, Masahiro Yamada
<yamada.m@jp.panasonic.com> wrote:

> CONFIG_TPL should not be enabled for boards that do not have TPL.
> CONFIG_SUPPORT_TPL introduced by this commit should be "select"ed
> by boards with TPL support and CONFIG_TPL should depend on it.

Actually, I see no CONFIG_SUPPORT_TPL in the patch, only
HAVE_TPL_SUPPORT. The commit message should match the patch content on
this point, should it not?

> Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
> ---
> 
>  Kconfig                          | 5 ++++-
>  arch/powerpc/cpu/mpc85xx/Kconfig | 5 +++++
>  2 files changed, 9 insertions(+), 1 deletion(-)
> 
> diff --git a/Kconfig b/Kconfig
> index 29e0b92..0b9be50 100644
> --- a/Kconfig
> +++ b/Kconfig
> @@ -73,6 +73,9 @@ config TPL_BUILD
>  config SUPPORT_SPL
>  	bool
>  
> +config HAVE_TPL_SUPPORT
> +	bool
> +
>  config SPL
>  	bool
>  	depends on SUPPORT_SPL
> @@ -83,7 +86,7 @@ config SPL
>  
>  config TPL
>  	bool
> -	depends on SPL
> +	depends on SPL && HAVE_TPL_SUPPORT
>  	prompt "Enable TPL" if !SPL_BUILD
>  	default y if TPL_BUILD
>  	default n
> diff --git a/arch/powerpc/cpu/mpc85xx/Kconfig b/arch/powerpc/cpu/mpc85xx/Kconfig
> index 6dcc45a..c5ebd40 100644
> --- a/arch/powerpc/cpu/mpc85xx/Kconfig
> +++ b/arch/powerpc/cpu/mpc85xx/Kconfig
> @@ -31,6 +31,7 @@ config TARGET_BSC9132QDS
>  config TARGET_C29XPCIE
>  	bool "Support C29XPCIE"
>  	select SUPPORT_SPL
> +	select SUPPORT_TPL
>  
>  config TARGET_P3041DS
>  	bool "Support P3041DS"
> @@ -77,10 +78,12 @@ config TARGET_MPC8572DS
>  config TARGET_P1010RDB
>  	bool "Support P1010RDB"
>  	select SUPPORT_SPL
> +	select SUPPORT_TPL
>  
>  config TARGET_P1022DS
>  	bool "Support P1022DS"
>  	select SUPPORT_SPL
> +	select SUPPORT_TPL
>  
>  config TARGET_P1023RDB
>  	bool "Support P1023RDB"
> @@ -88,10 +91,12 @@ config TARGET_P1023RDB
>  config TARGET_P1_P2_RDB
>  	bool "Support P1_P2_RDB"
>  	select SUPPORT_SPL
> +	select SUPPORT_TPL
>  
>  config TARGET_P1_P2_RDB_PC
>  	bool "Support p1_p2_rdb_pc"
>  	select SUPPORT_SPL
> +	select SUPPORT_TPL
>  
>  config TARGET_P1_TWR
>  	bool "Support p1_twr"


Amicalement,
-- 
Albert.

  reply	other threads:[~2014-10-11  8:56 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-25  9:19 [U-Boot] [PATCH 0/2] Introduce CONFIG_SUPPORT_SPL/TPL Masahiro Yamada
2014-09-25  9:19 ` [U-Boot] [PATCH 1/2] kconfig: add CONFIG_SUPPORT_SPL Masahiro Yamada
2014-09-25  9:19 ` [U-Boot] [PATCH 2/2] kconfig: add CONFIG_SUPPORT_TPL Masahiro Yamada
2014-10-11  8:56   ` Albert ARIBAUD [this message]
2014-10-11 17:04     ` Masahiro YAMADA
2014-10-11 20:49       ` Albert ARIBAUD

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1XcsTo-0007rL-Ob@janus \
    --to=albert.u.boot@aribaud.net \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.