Re: [Qemu-devel] [PATCH for 2.7] atomic: strip "const" from variables declared with typeof

[no-reply@patchew.org]

Hi,

Your series seems to have some coding style problems. See output below for
more information:

Message-id: 1470658774-16049-1-git-send-email-pbonzini@redhat.com
Type: series
Subject: [Qemu-devel] [PATCH for 2.7] atomic: strip "const" from variables declared with typeof

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git show --no-patch --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/1470658774-16049-1-git-send-email-pbonzini@redhat.com -> patchew/1470658774-16049-1-git-send-email-pbonzini@redhat.com
Switched to a new branch 'test'
5cd912b atomic: strip "const" from variables declared with typeof

=== OUTPUT BEGIN ===
Checking PATCH 1/1: atomic: strip "const" from variables declared with typeof...
WARNING: line over 80 characters
#38: FILE: include/qemu/atomic.h:29:
+#define typeof_strip_qual(expr)                                                          \

WARNING: line over 80 characters
#39: FILE: include/qemu/atomic.h:30:
+  typeof(                                                                                \

WARNING: line over 80 characters
#40: FILE: include/qemu/atomic.h:31:
+    __builtin_choose_expr(                                                               \

WARNING: line over 80 characters
#41: FILE: include/qemu/atomic.h:32:
+      __builtin_types_compatible_p(typeof(expr), signed char) ||                         \

WARNING: line over 80 characters
#42: FILE: include/qemu/atomic.h:33:
+        __builtin_types_compatible_p(typeof(expr), const signed char) ||                 \

WARNING: line over 80 characters
#43: FILE: include/qemu/atomic.h:34:
+        __builtin_types_compatible_p(typeof(expr), volatile signed char) ||              \

WARNING: Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt
#43: FILE: include/qemu/atomic.h:34:
+        __builtin_types_compatible_p(typeof(expr), volatile signed char) ||              \

WARNING: line over 80 characters
#44: FILE: include/qemu/atomic.h:35:
+        __builtin_types_compatible_p(typeof(expr), const volatile signed char),          \

WARNING: Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt
#44: FILE: include/qemu/atomic.h:35:
+        __builtin_types_compatible_p(typeof(expr), const volatile signed char),          \

WARNING: line over 80 characters
#45: FILE: include/qemu/atomic.h:36:
+      (signed char)1,                                                                    \

WARNING: line over 80 characters
#46: FILE: include/qemu/atomic.h:37:
+      __builtin_choose_expr(                                                             \

WARNING: line over 80 characters
#47: FILE: include/qemu/atomic.h:38:
+        __builtin_types_compatible_p(typeof(expr), unsigned char) ||                     \

WARNING: line over 80 characters
#48: FILE: include/qemu/atomic.h:39:
+          __builtin_types_compatible_p(typeof(expr), const unsigned char) ||             \

WARNING: line over 80 characters
#49: FILE: include/qemu/atomic.h:40:
+          __builtin_types_compatible_p(typeof(expr), volatile unsigned char) ||          \

WARNING: Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt
#49: FILE: include/qemu/atomic.h:40:
+          __builtin_types_compatible_p(typeof(expr), volatile unsigned char) ||          \

WARNING: line over 80 characters
#50: FILE: include/qemu/atomic.h:41:
+          __builtin_types_compatible_p(typeof(expr), const volatile unsigned char),      \

WARNING: Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt
#50: FILE: include/qemu/atomic.h:41:
+          __builtin_types_compatible_p(typeof(expr), const volatile unsigned char),      \

WARNING: line over 80 characters
#51: FILE: include/qemu/atomic.h:42:
+        (unsigned char)1,                                                                \

WARNING: line over 80 characters
#52: FILE: include/qemu/atomic.h:43:
+        __builtin_choose_expr(                                                           \

WARNING: line over 80 characters
#53: FILE: include/qemu/atomic.h:44:
+          __builtin_types_compatible_p(typeof(expr), signed short) ||                    \

WARNING: line over 80 characters
#54: FILE: include/qemu/atomic.h:45:
+            __builtin_types_compatible_p(typeof(expr), const signed short) ||            \

WARNING: line over 80 characters
#55: FILE: include/qemu/atomic.h:46:
+            __builtin_types_compatible_p(typeof(expr), volatile signed short) ||         \

WARNING: Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt
#55: FILE: include/qemu/atomic.h:46:
+            __builtin_types_compatible_p(typeof(expr), volatile signed short) ||         \

WARNING: line over 80 characters
#56: FILE: include/qemu/atomic.h:47:
+            __builtin_types_compatible_p(typeof(expr), const volatile signed short),     \

WARNING: Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt
#56: FILE: include/qemu/atomic.h:47:
+            __builtin_types_compatible_p(typeof(expr), const volatile signed short),     \

WARNING: line over 80 characters
#57: FILE: include/qemu/atomic.h:48:
+          (signed short)1,                                                               \

WARNING: line over 80 characters
#58: FILE: include/qemu/atomic.h:49:
+          __builtin_choose_expr(                                                         \

WARNING: line over 80 characters
#59: FILE: include/qemu/atomic.h:50:
+            __builtin_types_compatible_p(typeof(expr), unsigned short) ||                \

WARNING: line over 80 characters
#60: FILE: include/qemu/atomic.h:51:
+              __builtin_types_compatible_p(typeof(expr), const unsigned short) ||        \

WARNING: line over 80 characters
#61: FILE: include/qemu/atomic.h:52:
+              __builtin_types_compatible_p(typeof(expr), volatile unsigned short) ||     \

WARNING: Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt
#61: FILE: include/qemu/atomic.h:52:
+              __builtin_types_compatible_p(typeof(expr), volatile unsigned short) ||     \

WARNING: line over 80 characters
#62: FILE: include/qemu/atomic.h:53:
+              __builtin_types_compatible_p(typeof(expr), const volatile unsigned short), \

WARNING: Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt
#62: FILE: include/qemu/atomic.h:53:
+              __builtin_types_compatible_p(typeof(expr), const volatile unsigned short), \

WARNING: line over 80 characters
#63: FILE: include/qemu/atomic.h:54:
+            (unsigned short)1,                                                           \

ERROR: spaces required around that '+' (ctx:VxV)
#64: FILE: include/qemu/atomic.h:55:
+            (expr)+0)))))
                   ^

total: 1 errors, 34 warnings, 90 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1