Re: [Qemu-devel] [PATCH 0/5] blockjobs: Fix transactional race condition

[no-reply@patchew.org]

Hi,

Your series seems to have some coding style problems. See output below for
more information:

Message-id: 1470683381-16680-1-git-send-email-jsnow@redhat.com
Type: series
Subject: [Qemu-devel] [PATCH 0/5] blockjobs: Fix transactional race condition

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git show --no-patch --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/1470683381-16680-1-git-send-email-jsnow@redhat.com -> patchew/1470683381-16680-1-git-send-email-jsnow@redhat.com
Switched to a new branch 'test'
23f79b3 iotests: add transactional failure race test
8852e8a blockjob: add .clean property
0a62157 blockjob: refactor backup_start as backup_job_create
22acc76 blockjob: add block_job_start
e1cbf1b blockjob: fix dead pointer in txn list

=== OUTPUT BEGIN ===
Checking PATCH 1/5: blockjob: fix dead pointer in txn list...
Checking PATCH 2/5: blockjob: add block_job_start...
Checking PATCH 3/5: blockjob: refactor backup_start as backup_job_create...
WARNING: line over 80 characters
#433: FILE: blockdev.c:3396:
+    job = backup_job_create(job_id, bs, target_bs, speed, sync, NULL, on_source_error,

total: 0 errors, 1 warnings, 463 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 4/5: blockjob: add .clean property...
Checking PATCH 5/5: iotests: add transactional failure race test...
=== OUTPUT END ===

Test command exited with code: 1