Re: [Qemu-devel] [PATCH V3] hw/misc: Add simple measurement hardware

[no-reply@patchew.org]

Hi,

Your series seems to have some coding style problems. See output below for
more information:

Message-id: 1470688017-1127-1-git-send-email-mjg59@coreos.com
Type: series
Subject: [Qemu-devel] [PATCH V3] hw/misc: Add simple measurement hardware

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git show --no-patch --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/1470688017-1127-1-git-send-email-mjg59@coreos.com -> patchew/1470688017-1127-1-git-send-email-mjg59@coreos.com
Switched to a new branch 'test'
a976f6d hw/misc: Add simple measurement hardware

=== OUTPUT BEGIN ===
Checking PATCH 1/1: hw/misc: Add simple measurement hardware...
WARNING: line over 80 characters
#264: FILE: hw/misc/measurements.c:33:
+#define MEASUREMENT(obj) OBJECT_CHECK(MeasurementState, (obj), TYPE_MEASUREMENTS)

WARNING: line over 80 characters
#309: FILE: hw/misc/measurements.c:78:
+static void measurement_select(void *opaque, hwaddr addr, uint64_t val, unsigned size)

WARNING: braces {} are necessary for all arms of this statement
#313: FILE: hw/misc/measurements.c:82:
+    if (val > PCR_COUNT)
[...]

WARNING: line over 80 characters
#345: FILE: hw/misc/measurements.c:114:
+    if (qcrypto_hash_bytes(QCRYPTO_HASH_ALG_SHA1, tmpbuf, 40, &result, &resultlen, &err) == 0) {

WARNING: line over 80 characters
#356: FILE: hw/misc/measurements.c:125:
+static void measurement_value(void *opaque, hwaddr addr, uint64_t val, unsigned size)

WARNING: line over 80 characters
#367: FILE: hw/misc/measurements.c:136:
+static void log_data(MeasurementState *s, int pcrnum, uint8_t *hash, char *description)

WARNING: braces {} are necessary for all arms of this statement
#373: FILE: hw/misc/measurements.c:142:
+    if (!s->log)
[...]

WARNING: line over 80 characters
#386: FILE: hw/misc/measurements.c:155:
+void measurements_extend_data(int pcrnum, uint8_t *data, size_t len, char *description)

WARNING: line over 80 characters
#456: FILE: hw/misc/measurements.c:225:
+        VMSTATE_BUFFER_UNSAFE(measurements, MeasurementState, 0, PCR_COUNT * DIGEST_SIZE),

WARNING: line over 80 characters
#536: FILE: hw/misc/measurements.h:3:
+void measurements_extend_data(int pcrnum, uint8_t *data, size_t len, char *description);

ERROR: trailing whitespace
#626: FILE: qapi-schema.json:4366:
+# $

WARNING: line over 80 characters
#684: FILE: stubs/measurements.c:11:
+void measurements_extend_data(int pcrnum, uint8_t *data, size_t len, char *description)

total: 1 errors, 11 warnings, 564 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1