From: Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org, tiwai@suse.de, lgirdwood@gmail.com,
patches.audio@intel.com, broonie@kernel.org,
kbuild test robot <fengguang.wu@intel.com>,
"Subhransu S. Prusty" <subhransu.s.prusty@intel.com>
Subject: Applied "ASoC: Intel: Skylake: Fix uninitialized return" to the asoc tree
Date: Wed, 23 Aug 2017 16:54:19 +0100 [thread overview]
Message-ID: <E1dkXz1-0005Py-83@debutante> (raw)
In-Reply-To: <1503497232-21345-1-git-send-email-subhransu.s.prusty@intel.com>
The patch
ASoC: Intel: Skylake: Fix uninitialized return
has been applied to the asoc tree at
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
>From 9149916f1e8c912c585ddebf12a98e99bd81aafe Mon Sep 17 00:00:00 2001
From: "Subhransu S. Prusty" <subhransu.s.prusty@intel.com>
Date: Wed, 23 Aug 2017 19:37:12 +0530
Subject: [PATCH] ASoC: Intel: Skylake: Fix uninitialized return
On failure to get dsp_ops, dsp_init returns error without assigning ret. ret
is assigned in code path which will never be executed. Fix it.
Fixes: f77d443c4c29 ("ASoC: Intel: Skylake: Fix to free resources for dsp_init failure"
Reported-by: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: Subhransu S. Prusty <subhransu.s.prusty@intel.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
sound/soc/intel/skylake/skl-messages.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/intel/skylake/skl-messages.c b/sound/soc/intel/skylake/skl-messages.c
index f0f11f597b21..697d07bc1b5a 100644
--- a/sound/soc/intel/skylake/skl-messages.c
+++ b/sound/soc/intel/skylake/skl-messages.c
@@ -278,8 +278,8 @@ int skl_init_dsp(struct skl *skl)
ops = skl_get_dsp_ops(skl->pci->device);
if (!ops) {
- goto unmap_mmio;
ret = -EIO;
+ goto unmap_mmio;
}
loader_ops = ops->loader_ops();
--
2.14.1
next prev parent reply other threads:[~2017-08-23 15:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-23 14:07 [PATCH] ASoC: Intel: Skylake: Fix uninitialized return Subhransu S. Prusty
2017-08-23 15:54 ` Mark Brown [this message]
2017-08-25 5:41 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1dkXz1-0005Py-83@debutante \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=fengguang.wu@intel.com \
--cc=lgirdwood@gmail.com \
--cc=patches.audio@intel.com \
--cc=subhransu.s.prusty@intel.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.