From mboxrd@z Thu Jan 1 00:00:00 1970 From: Al Viro Subject: Subject: [RFC][PATCH 04/11] stmmac: fix breakage in stmmac_hw_setup() Date: Fri, 05 Jan 2018 19:31:58 +0000 Message-ID: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: , Cavallaro@ftp.linux.org.uk, Giuseppe@ftp.linux.org.uk To: netdev@vger.kernel.org Return-path: Received: from zeniv.linux.org.uk ([195.92.253.2]:45500 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752462AbeAETb7 (ORCPT ); Fri, 5 Jan 2018 14:31:59 -0500 Sender: netdev-owner@vger.kernel.org List-ID: Since "drivers: net: stmmac: reworking the PCS code" ->pcs_ctrl_ane() had been taking iomem address to access as the first argument; its predecessor (->ctrl_ane()) used to take struct mac_device_info instead. One of the callers had not been converted; as the result, instead of reading and modifying a word in card iomem we read and modify a word in (or near) the in-core strucct mac_device_info. Fixes: 70523e639bf8 (drivers: net: stmmac: reworking the PCS code) Cc: stable@vger.kernel.org Signed-off-by: Al Viro --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c index d9c98fd810bb..68ed903f0ac8 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c @@ -2571,7 +2571,7 @@ static int stmmac_hw_setup(struct net_device *dev, bool init_ptp) } if (priv->hw->pcs && priv->hw->mac->pcs_ctrl_ane) - priv->hw->mac->pcs_ctrl_ane(priv->hw, 1, priv->hw->ps, 0); + priv->hw->mac->pcs_ctrl_ane(priv->ioaddr, 1, priv->hw->ps, 0); /* set TX and RX rings length */ stmmac_set_rings_length(priv); -- 2.11.0