All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: tiwai@suse.de, liam.r.girdwood@linux.intel.com,
	alsa-devel@alsa-project.org, broonie@kernel.org,
	vkoul@kernel.org
Subject: Applied "ASoC: Intel: Skylake: cleanup before moving ACPI tables" to the asoc tree
Date: Tue, 19 Jun 2018 16:24:42 +0100	[thread overview]
Message-ID: <E1fVIUs-0002QE-48@debutante> (raw)
In-Reply-To: <20180618182942.4925-3-pierre-louis.bossart@linux.intel.com>

The patch

   ASoC: Intel: Skylake: cleanup before moving ACPI tables

has been applied to the asoc tree at

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git 

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.  

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

>From 5f15f267daf81a4c7c2a1cd2a0d6743ec7fc8b59 Mon Sep 17 00:00:00 2001
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Date: Mon, 18 Jun 2018 13:29:36 -0500
Subject: [PATCH] ASoC: Intel: Skylake: cleanup before moving ACPI tables

There is no need to deal with DMICs if the DSP is not present and
there is no ACPI machine ID found.

Simplify before moving these ACPI tables to sound/soc/intel/common

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
 sound/soc/intel/skylake/skl.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/sound/soc/intel/skylake/skl.c b/sound/soc/intel/skylake/skl.c
index 0a8f0768e987..6dec748e8949 100644
--- a/sound/soc/intel/skylake/skl.c
+++ b/sound/soc/intel/skylake/skl.c
@@ -500,10 +500,12 @@ static int skl_find_machine(struct skl *skl, void *driver_data)
 
 	skl->mach = mach;
 	skl->fw_name = mach->fw_filename;
-	pdata = skl->mach->pdata;
+	pdata = mach->pdata;
 
-	if (mach->pdata)
+	if (pdata) {
 		skl->use_tplg_pcm = pdata->use_tplg_pcm;
+		pdata->dmic_num = skl_get_dmic_geo(skl);
+	}
 
 	return 0;
 }
@@ -930,8 +932,6 @@ static int skl_probe(struct pci_dev *pci,
 
 	pci_set_drvdata(skl->pci, ebus);
 
-	skl_dmic_data.dmic_num = skl_get_dmic_geo(skl);
-
 	/* check if dsp is there */
 	if (bus->ppcap) {
 		/* create device for dsp clk */
-- 
2.17.1

  reply	other threads:[~2018-06-19 15:24 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-18 18:29 [PATCH 0/8] ASoC: Intel: common ACPI tables - take2 Pierre-Louis Bossart
2018-06-18 18:29 ` [PATCH 1/8] ASoC: Intel: broxton: reduce machine name for bxt_da7219_max98357a Pierre-Louis Bossart
2018-06-18 18:29 ` [PATCH 2/8] ASoC: Intel: Skylake: cleanup before moving ACPI tables Pierre-Louis Bossart
2018-06-19 15:24   ` Mark Brown [this message]
2018-06-18 18:29 ` [PATCH 3/8] ASoC: Intel: move SKL+ codec ACPI tables to common directory Pierre-Louis Bossart
2018-06-19 15:24   ` Applied "ASoC: Intel: move SKL+ codec ACPI tables to common directory" to the asoc tree Mark Brown
2018-06-18 18:29 ` [PATCH 4/8] ASoC: Intel: common: Add Geminilake Dialog+Maxim machine driver entry Pierre-Louis Bossart
2018-06-19 15:24   ` Applied "ASoC: Intel: common: Add Geminilake Dialog+Maxim machine driver entry" to the asoc tree Mark Brown
2018-06-18 18:29 ` [PATCH 5/8] ASoC: Intel: common: add firmware/topology information for SOF Pierre-Louis Bossart
2018-06-19 15:24   ` Applied "ASoC: Intel: common: add firmware/topology information for SOF" to the asoc tree Mark Brown
2018-06-18 18:29 ` [PATCH 6/8] ASoC: Intel: common: add Geminilake Realtek+Maxim machine driver entry Pierre-Louis Bossart
2018-06-18 18:29 ` [PATCH 7/8] ASoC: Intel: common: add entries for SOF-based machine drivers Pierre-Louis Bossart
2018-06-19 15:24   ` Applied "ASoC: Intel: common: add entries for SOF-based machine drivers" to the asoc tree Mark Brown
2018-06-18 18:29 ` [PATCH 8/8] ASoC: Intel: common: fix copy/paste issue with SOF/broadwell topology file Pierre-Louis Bossart
2018-06-19 15:24   ` Applied "ASoC: Intel: common: fix copy/paste issue with SOF/broadwell topology file" to the asoc tree Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1fVIUs-0002QE-48@debutante \
    --to=broonie@kernel.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=liam.r.girdwood@linux.intel.com \
    --cc=pierre-louis.bossart@linux.intel.com \
    --cc=tiwai@suse.de \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.