All of lore.kernel.org
 help / color / mirror / Atom feed
From: Russell King <rmk+kernel@armlinux.org.uk>
To: Andrew Lunn <andrew@lunn.ch>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Vivien Didelot <vivien.didelot@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>, netdev@vger.kernel.org
Subject: [PATCH net-next 2/3] net: dsa: mv88e6xxx: add support for bridge flags
Date: Sun, 17 Feb 2019 14:25:12 +0000	[thread overview]
Message-ID: <E1gvNNY-0006Y7-NF@rmk-PC.armlinux.org.uk> (raw)
In-Reply-To: <20190217142414.cjtmpi5y2l5rtdlb@shell.armlinux.org.uk>

Add support for the bridge flags to Marvell 88e6xxx bridges, allowing
the multicast and unicast flood properties to be controlled.  These
can be controlled on a per-port basis via commands such as:

	bridge link set dev lan1 flood on|off
	bridge link set dev lan1 mcast_flood on|off

Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
---
 drivers/net/dsa/mv88e6xxx/chip.c | 33 +++++++++++++++++++++++++++++++++
 1 file changed, 33 insertions(+)

diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c
index 32e7af5caa69..b75a865a293d 100644
--- a/drivers/net/dsa/mv88e6xxx/chip.c
+++ b/drivers/net/dsa/mv88e6xxx/chip.c
@@ -4692,6 +4692,37 @@ static int mv88e6xxx_port_mdb_del(struct dsa_switch *ds, int port,
 	return err;
 }
 
+static int mv88e6xxx_port_bridge_flags(struct dsa_switch *ds, int port,
+				       unsigned long flags)
+{
+	struct mv88e6xxx_chip *chip = ds->priv;
+	bool unicast, multicast;
+	int ret = -EOPNOTSUPP;
+
+	unicast = dsa_is_cpu_port(ds, port) || dsa_is_dsa_port(ds, port) ||
+		flags & BR_FLOOD;
+	multicast = flags & BR_MCAST_FLOOD;
+
+	mutex_lock(&chip->reg_lock);
+	if (chip->info->ops->port_set_egress_floods)
+		ret = chip->info->ops->port_set_egress_floods(chip, port,
+							      unicast,
+							      multicast);
+	mutex_unlock(&chip->reg_lock);
+
+	return ret;
+}
+
+static unsigned long mv88e6xxx_bridge_flags_support(struct dsa_switch *ds)
+{
+	unsigned long support = 0;
+
+	if (chip->info->ops->port_set_egress_floods)
+		support |= BR_FLOOD | BR_MCAST_FLOOD;
+
+	return support;
+}
+
 static const struct dsa_switch_ops mv88e6xxx_switch_ops = {
 #if IS_ENABLED(CONFIG_NET_DSA_LEGACY)
 	.probe			= mv88e6xxx_drv_probe,
@@ -4719,6 +4750,8 @@ static const struct dsa_switch_ops mv88e6xxx_switch_ops = {
 	.set_ageing_time	= mv88e6xxx_set_ageing_time,
 	.port_bridge_join	= mv88e6xxx_port_bridge_join,
 	.port_bridge_leave	= mv88e6xxx_port_bridge_leave,
+	.port_bridge_flags	= mv88e6xxx_port_bridge_flags,
+	.bridge_flags_support	= mv88e6xxx_bridge_flags_support,
 	.port_stp_state_set	= mv88e6xxx_port_stp_state_set,
 	.port_fast_age		= mv88e6xxx_port_fast_age,
 	.port_vlan_filtering	= mv88e6xxx_port_vlan_filtering,
-- 
2.7.4


  parent reply	other threads:[~2019-02-17 14:26 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-17 14:24 [PATCH net-next 0/3] net: dsa: mv88e6xxx: fix IPv6 Russell King - ARM Linux admin
2019-02-17 14:25 ` [PATCH net-next 1/3] net: dsa: add support for bridge flags Russell King
2019-02-17 21:37   ` Florian Fainelli
2019-02-17 22:04     ` Russell King - ARM Linux admin
2019-02-17 22:07       ` Florian Fainelli
2019-02-18  0:50         ` Russell King - ARM Linux admin
2019-02-18 11:23           ` Russell King - ARM Linux admin
2019-02-19 15:42             ` Vivien Didelot
2019-02-17 14:25 ` Russell King [this message]
2019-02-17 21:38   ` [PATCH net-next 2/3] net: dsa: mv88e6xxx: " Florian Fainelli
2019-02-17 14:25 ` [PATCH net-next 3/3] net: dsa: mv88e6xxx: defautl to multicast and unicast flooding Russell King
2019-02-17 14:27   ` Russell King - ARM Linux admin
2019-02-17 16:34     ` Russell King - ARM Linux admin
2019-02-17 21:45       ` Florian Fainelli
2019-02-17 21:58         ` Russell King - ARM Linux admin
2019-02-17 22:03           ` Florian Fainelli
2019-02-17 22:19             ` Russell King - ARM Linux admin
2019-02-17 22:30               ` Florian Fainelli
2019-02-17 16:31 ` [PATCH net-next v2 0/3] net: dsa: mv88e6xxx: fix IPv6 Russell King - ARM Linux admin
2019-02-17 16:32   ` [PATCH net-next v2 1/3] net: dsa: add support for bridge flags Russell King
2019-02-17 16:32   ` [PATCH net-next v2 2/3] net: dsa: mv88e6xxx: " Russell King
2019-02-19 16:16     ` Vivien Didelot
2019-02-19 16:24       ` Russell King - ARM Linux admin
2019-02-19 17:00         ` Vivien Didelot
2019-02-19 17:14           ` Russell King - ARM Linux admin
2019-02-19 17:38             ` Vivien Didelot
2019-02-19 17:44               ` Florian Fainelli
2019-02-19 18:20                 ` Vivien Didelot
2019-02-19 18:08               ` Russell King - ARM Linux admin
2019-02-19 19:04                 ` Vivien Didelot
2019-02-19 19:10                   ` Russell King - ARM Linux admin
2019-02-19 19:37                     ` Florian Fainelli
2019-02-19 19:56                     ` Vivien Didelot
2019-02-19 22:52                       ` Russell King - ARM Linux admin
2019-02-19 17:00       ` Russell King - ARM Linux admin
2019-02-19 17:23         ` Vivien Didelot
2019-02-19 17:27           ` Russell King - ARM Linux admin
2019-02-19 23:34         ` Russell King - ARM Linux admin
2019-02-19 23:53           ` Florian Fainelli
2019-02-20  0:07             ` Russell King - ARM Linux admin
2019-02-17 16:32   ` [PATCH net-next v2 3/3] net: dsa: mv88e6xxx: default to multicast and unicast flooding Russell King
2019-02-18 12:53     ` Russell King - ARM Linux admin
2019-02-19 16:05       ` Vivien Didelot
2019-02-19 16:18         ` Russell King - ARM Linux admin
2019-02-18 11:34   ` [PATCH net-next v2 0/3] net: dsa: mv88e6xxx: fix IPv6 Russell King - ARM Linux admin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1gvNNY-0006Y7-NF@rmk-PC.armlinux.org.uk \
    --to=rmk+kernel@armlinux.org.uk \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=f.fainelli@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=vivien.didelot@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.