All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Russell King (Oracle)" <rmk+kernel@armlinux.org.uk>
To: Andrew Lunn <andrew@lunn.ch>, Heiner Kallweit <hkallweit1@gmail.com>
Cc: Abhishek Chauhan <quic_abchauha@quicinc.com>,
	Alexandre Torgue <alexandre.torgue@foss.st.com>,
	Alexis Lothore <alexis.lothore@bootlin.com>,
	"Alexis Lothor__" <alexis.lothore@bootlin.com>,
	Andrew Lunn <andrew+netdev@lunn.ch>,
	Boon Khai Ng <boon.khai.ng@altera.com>,
	Choong Yong Liang <yong.liang.choong@linux.intel.com>,
	Daniel Machon <daniel.machon@microchip.com>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Faizal Rahim <faizal.abdul.rahim@linux.intel.com>,
	Furong Xu <0x1207@gmail.com>, Huacai Chen <chenhuacai@kernel.org>,
	Inochi Amaoto <inochiama@gmail.com>,
	Jacob Keller <jacob.e.keller@intel.com>,
	Jakub Kicinski <kuba@kernel.org>,
	"Jan Petrous (OSS)" <jan.petrous@oss.nxp.com>,
	Jisheng Zhang <jszhang@kernel.org>, Kees Cook <kees@kernel.org>,
	Kunihiko Hayashi <hayashi.kunihiko@socionext.com>,
	Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
	Ley Foon Tan <leyfoon.tan@starfivetech.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-arm-msm@vger.kernel.org,
	linux-stm32@st-md-mailman.stormreply.com,
	Mateusz Polchlopek <mateusz.polchlopek@intel.com>,
	Matthew Gerlach <matthew.gerlach@altera.com>,
	Maxime Chevallier <maxime.chevallier@bootlin.com>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	netdev@vger.kernel.org, Oleksij Rempel <o.rempel@pengutronix.de>,
	Paolo Abeni <pabeni@redhat.com>,
	Rohan G Thomas <rohan.g.thomas@altera.com>,
	Shenwei Wang <shenwei.wang@nxp.com>,
	Simon Horman <horms@kernel.org>,
	Song Yoong Siang <yoong.siang.song@intel.com>,
	Swathi K S <swathi.ks@samsung.com>,
	Tiezhu Yang <yangtiezhu@loongson.cn>,
	Vinod Koul <vkoul@kernel.org>,
	Vladimir Oltean <olteanv@gmail.com>,
	Vladimir Oltean <vladimir.oltean@nxp.com>,
	Yu-Chun Lin <eleanor15x@gmail.com>
Subject: [PATCH RFC net-next v2 09/19] net: stmmac: simplify stmmac_check_pcs_mode()
Date: Sun, 28 Sep 2025 10:20:49 +0100	[thread overview]
Message-ID: <E1v2naL-00000007oFE-0d6b@rmk-PC.armlinux.org.uk> (raw)
In-Reply-To: <aNj8U4xPJ0JepmZs@shell.armlinux.org.uk>

Now that we only support one mode, simplify stmmac_check_pcs_mode().

Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
---
 .../net/ethernet/stmicro/stmmac/stmmac_main.c   | 17 +++++++++--------
 1 file changed, 9 insertions(+), 8 deletions(-)

diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
index 414a00ab5012..94b615444734 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
@@ -1086,22 +1086,23 @@ static const struct phylink_mac_ops stmmac_phylink_mac_ops = {
 static void stmmac_check_pcs_mode(struct stmmac_priv *priv)
 {
 	int interface = priv->plat->phy_interface;
+	int speed = priv->plat->mac_port_sel_speed;
 
 	if (priv->dma_cap.pcs && interface == PHY_INTERFACE_MODE_SGMII) {
 		netdev_dbg(priv->dev, "PCS SGMII support enabled\n");
 		priv->hw->pcs = STMMAC_PCS_SGMII;
-	}
-
-	/* PS and related bits will be programmed according to the speed */
-	if (priv->hw->pcs) {
-		int speed = priv->plat->mac_port_sel_speed;
 
-		if ((speed == SPEED_10) || (speed == SPEED_100) ||
-		    (speed == SPEED_1000)) {
+		switch (speed) {
+		case SPEED_10:
+		case SPEED_100:
+		case SPEED_1000:
 			priv->hw->ps = speed;
-		} else {
+			break;
+
+		default:
 			dev_warn(priv->device, "invalid port speed\n");
 			priv->hw->ps = 0;
+			break;
 		}
 	}
 }
-- 
2.47.3



  parent reply	other threads:[~2025-09-28  9:30 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-28  9:13 [PATCH RFC net-next v2 0/19] net: stmmac: experimental PCS conversion Russell King (Oracle)
2025-09-28  9:20 ` [PATCH RFC net-next v2 01/19] net: stmmac: remove broken PCS code Russell King (Oracle)
2025-09-28  9:20 ` [PATCH RFC net-next v2 02/19] net: stmmac: remove xstats.pcs_* members Russell King (Oracle)
2025-09-28  9:20 ` [PATCH RFC net-next v2 03/19] net: stmmac: remove SGMII/RGMII/SMII interrupt handling Russell King (Oracle)
2025-09-28  9:20 ` [PATCH RFC net-next v2 04/19] net: stmmac: remove PCS "mode" pause handling Russell King (Oracle)
2025-09-28  9:20 ` [PATCH RFC net-next v2 05/19] net: stmmac: remove unused PCS loopback support Russell King (Oracle)
2025-09-28  9:20 ` [PATCH RFC net-next v2 06/19] net: stmmac: remove hw->ps xxx_core_init() hardware setup Russell King (Oracle)
2025-09-28  9:20 ` [PATCH RFC net-next v2 07/19] net: stmmac: remove RGMII "pcs" mode Russell King (Oracle)
2025-09-28  9:20 ` [PATCH RFC net-next v2 08/19] net: stmmac: move reverse-"pcs" mode setup to stmmac_check_pcs_mode() Russell King (Oracle)
2025-09-28  9:20 ` Russell King (Oracle) [this message]
2025-09-28  9:20 ` [PATCH RFC net-next v2 10/19] net: stmmac: hw->ps becomes hw->reverse_sgmii_enable Russell King (Oracle)
2025-09-28  9:20 ` [PATCH RFC net-next v2 11/19] net: stmmac: do not require snps,ps-speed for SGMII Russell King (Oracle)
2025-09-28  9:21 ` [PATCH RFC net-next v2 12/19] net: stmmac: only call stmmac_pcs_ctrl_ane() for integrated SGMII PCS Russell King (Oracle)
2025-09-28  9:21 ` [PATCH RFC net-next v2 13/19] net: stmmac: convert to phylink PCS support Russell King (Oracle)
2025-09-28  9:21 ` [PATCH RFC net-next v2 14/19] net: stmmac: only initialise PCS when present Russell King (Oracle)
2025-09-28  9:21 ` [PATCH RFC net-next v2 15/19] net: stmmac: add stmmac_mac_irq_modify() Russell King (Oracle)
2025-09-28  9:21 ` [PATCH RFC net-next v2 16/19] net: stmmac: add support for controlling PCS interrupts Russell King (Oracle)
2025-09-28  9:21 ` [PATCH RFC net-next v2 17/19] net: stmmac: configure AN control according to phylink Russell King (Oracle)
2025-09-28  9:21 ` [PATCH RFC net-next v2 18/19] net: stmmac: report PCS configuration changes Russell King (Oracle)
2025-09-28  9:21 ` [PATCH RFC net-next v2 19/19] net: stmmac: add support specifying PCS supported interfaces Russell King (Oracle)
2025-10-03 13:32 ` [PATCH RFC net-next v2 0/19] net: stmmac: experimental PCS conversion Maxime Chevallier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1v2naL-00000007oFE-0d6b@rmk-PC.armlinux.org.uk \
    --to=rmk+kernel@armlinux.org.uk \
    --cc=0x1207@gmail.com \
    --cc=alexandre.torgue@foss.st.com \
    --cc=alexis.lothore@bootlin.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=andrew@lunn.ch \
    --cc=boon.khai.ng@altera.com \
    --cc=chenhuacai@kernel.org \
    --cc=daniel.machon@microchip.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=eleanor15x@gmail.com \
    --cc=faizal.abdul.rahim@linux.intel.com \
    --cc=hayashi.kunihiko@socionext.com \
    --cc=hkallweit1@gmail.com \
    --cc=horms@kernel.org \
    --cc=inochiama@gmail.com \
    --cc=jacob.e.keller@intel.com \
    --cc=jan.petrous@oss.nxp.com \
    --cc=jszhang@kernel.org \
    --cc=kees@kernel.org \
    --cc=kuba@kernel.org \
    --cc=leyfoon.tan@starfivetech.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=mateusz.polchlopek@intel.com \
    --cc=matthew.gerlach@altera.com \
    --cc=maxime.chevallier@bootlin.com \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=o.rempel@pengutronix.de \
    --cc=olteanv@gmail.com \
    --cc=pabeni@redhat.com \
    --cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
    --cc=quic_abchauha@quicinc.com \
    --cc=rohan.g.thomas@altera.com \
    --cc=shenwei.wang@nxp.com \
    --cc=swathi.ks@samsung.com \
    --cc=vkoul@kernel.org \
    --cc=vladimir.oltean@nxp.com \
    --cc=yangtiezhu@loongson.cn \
    --cc=yong.liang.choong@linux.intel.com \
    --cc=yoong.siang.song@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.