Re: [PATCH 00/10] hwmon: (oxpsensors) Add 2024 OneXPlayer line-up, add charge limiting and turbo LED, fix ABI

["Derek J. Clark" <derekjohn.clark@gmail.com>]

On December 26, 2024 1:08:02 PM PST, Guenter Roeck <linux@roeck-us.net> wrote:
>On Thu, Dec 26, 2024 at 12:27:30PM +0100, Antheas Kapenekakis wrote:
>> This three part series updates the oxpsensors module to bring it in line
>> with its Windows OneXPlayer counterpart. First, it adds support for all
>> 2024 OneXPlayer handhelds and their special variants.
>> 
>> Then, it adds the new charge limiting and bypass features that were first
>> introduced in the X1 and retrofit to older OneXFly variants and for
>> controlling the turbo led found in the X1 models. For Bypass, it adds a new
>> bypass variant BypassS0 that is only active while the device is in the S0
>> state.
>> 
>
>This is a hardware monitoring driver. It is not a charge controller driver,
>and it is not a LED controller driver. If such control is wanted/needed for
>this system, it should be implemented either as mfd device with client drivers,
>or the entire driver should be moved to platform drivers if there is a desire
>to keep it as single driver.
>
>Guenter

I think moving this to x86 platform makes a lot of sense to ensure two separate drivers can't do async writes to the EC. We probably should have done that when adding the turbo button toggle anyway. I'll coordinate that effort with Tobias and Antheas directly before moving forward.

Thanks Guenter,
- Derek