From: "Sebastian Herbszt" <herbszt@gmx.de>
To: qemu-devel@nongnu.org,
Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
Cc: Marcelo Tosatti <mtosatti@redhat.com>, Avi Kivity <avi@redhat.com>
Subject: [Qemu-devel] Re: [6392] Add BIOS fixes from KVM tree
Date: Thu, 22 Jan 2009 20:36:16 +0100 [thread overview]
Message-ID: <E81807C3EEE7495D8312E7C2D1674F19@FSCPC> (raw)
In-Reply-To: <4977BA68.2070206@gmx.net>
Carl-Daniel Hailfinger wrote:
> Hi,
>
> I'm sorry to say that, but my tests showed that
> 0004_kvm-bios-add-mtrr-support.patch is buggy. It reads MSR_MTRRcap
> unconditionally which is not allowed if the CPUID features do not have
> CPUID_MTRR set. Real hardware will #GP in that case.
> This was found by my MSR access tracing patch.
>
> Please add a check for the CPUID_MTRR feature bit before reading
> MSR_MTRRcap. Thanks.
I am in the process of adding this to Bochs. I added checks for CPUID_MTRR
and CPUID_MSR and those could go in on next merge.
- Sebastian
next prev parent reply other threads:[~2009-01-22 19:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-21 21:46 [Qemu-devel] [6392] Add BIOS fixes from KVM tree Anthony Liguori
2009-01-22 0:14 ` Carl-Daniel Hailfinger
2009-01-22 19:36 ` Sebastian Herbszt [this message]
2009-01-22 20:53 ` Marcelo Tosatti
2009-01-22 21:15 ` Anthony Liguori
2009-01-22 22:51 ` Sebastian Herbszt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E81807C3EEE7495D8312E7C2D1674F19@FSCPC \
--to=herbszt@gmx.de \
--cc=avi@redhat.com \
--cc=c-d.hailfinger.devel.2006@gmx.net \
--cc=mtosatti@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.