From: Ben Knoble <ben.knoble@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, kristofferhaugsbakk@fastmail.com,
Kristoffer Haugsbakk <code@khaugsbakk.name>
Subject: Re: [PATCH v2 0/5] format-rev: add --abbrev, --color, and --date
Date: Thu, 3 Sep 2026 11:07:50 -0400 [thread overview]
Message-ID: <EBCF44E8-9952-454F-A164-0B7CF273FB30@gmail.com> (raw)
In-Reply-To: <xmqqse40ei5f.fsf@gitster.g>
> Le 26 août 2026 à 16:33, Junio C Hamano <gitster@pobox.com> a écrit :
>
> kristofferhaugsbakk@fastmail.com writes:
>
>> From: Kristoffer Haugsbakk <code@khaugsbakk.name>
>>
>> Topic name (applied): kh/format-rev-more-options
>>
>> Topic summary: Add three more options for controlling the formatting. Also
>> do some minor refactoring and text fixes as preparatory steps.
>>
>> § Changes in v2
>>
>> See the patch notes for details.
>>
>> • Use designated initializer syntax. That’s more readable since you pair
>> the field with the value and you can omit zero-value fields.
>>
>> https://lore.kernel.org/git/xmqqfr0hswxm.fsf@gitster.g/
>> • Fix useless `BUG` placements https://lore.kernel.org/git/xmqqfr0hswxm.fsf@gitster.g/
>> • Add preliminary patch “place BUG calls first in callback” for existing
>> `BUG` statement placement
>> • Based on the previous point
>> • Patch “learn --abbrev, --color, and --date”: test a few more options
>
> Nobody is interested in reviewing these patches? They looked more
> or less OKish to me, but I am not the best person to review this
> series, as I do not see much point in this experimental command.
> It would be nice to see reviews from those who are more invested
> in seeing the command work better than I am.
>
> Thanks.
Reviewing these are on my list. They’ve been there for a while,
now, though, and no promises on timing :/ my personal priorities
shifted rather quickly for the weekend with the recent 1Password
announcement ://
PS hopefully this wrapping is better from my mobile device,
I’m guessing at the width to hard-break as roughly 1.3 screen lines :)
next prev parent reply other threads:[~2026-09-03 15:08 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-13 17:23 [PATCH 0/4] format-rev: add --abbrev, --color, and --date kristofferhaugsbakk
2026-08-13 17:23 ` [PATCH 1/4] format-rev: use lower case for opts description kristofferhaugsbakk
2026-08-13 17:23 ` [PATCH 2/4] format-rev: factor option variables into a struct kristofferhaugsbakk
2026-08-13 18:21 ` Junio C Hamano
2026-08-14 10:54 ` Kristoffer Haugsbakk
2026-08-13 17:23 ` [PATCH 3/4] doc: rev-list-options.adoc: factor out --date alts kristofferhaugsbakk
2026-08-13 17:24 ` [PATCH 4/4] format-rev: learn --abbrev, --color, and --date kristofferhaugsbakk
2026-08-15 2:17 ` Junio C Hamano
2026-08-17 14:48 ` Kristoffer Haugsbakk
2026-08-17 16:54 ` Junio C Hamano
2026-08-18 5:11 ` Kristoffer Haugsbakk
2026-08-18 9:57 ` [PATCH v2 0/5] format-rev: add " kristofferhaugsbakk
2026-08-18 9:57 ` [PATCH v2 1/5] format-rev: use lower case for opts description kristofferhaugsbakk
2026-08-18 9:57 ` [PATCH v2 2/5] format-rev: place BUG calls first in callback kristofferhaugsbakk
2026-08-18 9:57 ` [PATCH v2 3/5] format-rev: factor option variables into a struct kristofferhaugsbakk
2026-08-18 9:57 ` [PATCH v2 4/5] doc: rev-list-options.adoc: factor out --date alts kristofferhaugsbakk
2026-08-18 9:57 ` [PATCH v2 5/5] format-rev: learn --abbrev, --color, and --date kristofferhaugsbakk
2026-08-26 20:33 ` [PATCH v2 0/5] format-rev: add " Junio C Hamano
2026-09-03 15:07 ` Ben Knoble [this message]
2026-09-03 15:22 ` Kristoffer Haugsbakk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=EBCF44E8-9952-454F-A164-0B7CF273FB30@gmail.com \
--to=ben.knoble@gmail.com \
--cc=code@khaugsbakk.name \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=kristofferhaugsbakk@fastmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.