From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NA7RV-0004yy-8W for qemu-devel@nongnu.org; Mon, 16 Nov 2009 14:40:53 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NA7RQ-0004wK-Ki for qemu-devel@nongnu.org; Mon, 16 Nov 2009 14:40:52 -0500 Received: from [199.232.76.173] (port=33731 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NA7RQ-0004wF-Dn for qemu-devel@nongnu.org; Mon, 16 Nov 2009 14:40:48 -0500 Received: from mail.gmx.net ([213.165.64.20]:53107) by monty-python.gnu.org with smtp (Exim 4.60) (envelope-from ) id 1NA7RO-0002aT-FB for qemu-devel@nongnu.org; Mon, 16 Nov 2009 14:40:48 -0500 Message-ID: From: "Sebastian Herbszt" References: <7F4F5A74116D4AACB25508580EA62397@FSCPC> In-Reply-To: Date: Mon, 16 Nov 2009 20:38:52 +0100 MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset="iso-8859-1"; reply-type=original Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: Build failure on mingw List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: malc Cc: qemu-devel@nongnu.org malc wrote: > On Sat, 14 Nov 2009, Sebastian Herbszt wrote: > >> v0.11.0-rc0-1630-g51cc2e7 fails to build on mingw with gcc version 3.4.5 >> (mingw32 special) >> and GNU Make version 3.79.1. >> >> gcc -I/home/sh/vm/qemu/v0.11.0-rc0-1630-g51cc2e7/slirp -Wold-style-definition >> -I. >> -I/home/sh/vm/qemu/v0.11.0-rc0-1630-g51cc2e7 -U_FORTIFY_SOURCE -D_GNU_SOURCE >> -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE >> -Wstrict-prototypes -Wredundant-decls -Wall -Wundef -Wendif-labels >> -Wwrite-strings -Wmissing-prototypes -fno-strict-aliasing >> -m32 -DWIN32_LEAN_AND_MEAN -DWINVER=0x501 >> -MMD -MP -MT audio/mixeng.o -O2 -g -c -o audio/mixeng.o audio/mixeng.c >> >> gcc -I/home/sh/vm/qemu/v0.11.0-rc0-1630-g51cc2e7/slirp -Wold-style-definition >> -I. >> -I/home/sh/vm/qemu/v0.11.0-rc0-1630-g51cc2e7 -U_FORTIFY_SOURCE -D_GNU_SOURCE >> -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE >> -Wstrict-prototypes -Wredundant-decls -Wall -Wundef -Wendif-labels >> -Wwrite-strings -Wmissing-prototypes -fno-strict-aliasing >> -m32 -DWIN32_LEAN_AND_MEAN -DWINVER=0x501 >> -MMD -MP -MT -I/mingw/include/SDL -D_GNU_SOURCE=1 -Dmain=SDL_main -O2 -g -c -o >> audio/sdlaudio.o audio/sdlaudio.c >> audio/sdlaudio.c:24:17: warning: SDL.h: No such file or directory >> audio/sdlaudio.c:25:24: warning: SDL_thread.h: No such file or directory >> >> Notice the missing parameter for "-MT" with sdlaudio, but not mixeng. Before >> commit >> 02d5467e9f43dac05f04999e387108ca4c8ba140 "-MT" was followed by >> "-U_FORTIFY_SOURCE", but now it's "-I/mingw/include/SDL" >> which gets swallowed. > > Neither is/was correct, does escaping $@ in rules make (i.e. \$@) have > any effect? Changing it to \$@ makes it compile again: $ grep MMD rules.mak QEMU_CFLAGS += -MMD -MP -MT \$@ gcc -I/home/sh/vm/qemu/v0.11.0-rc0-1630-g51cc2e7-nox-fixed/slirp -Wold-style-definition -I. -I/home/sh/vm/qemu/v0.11.0-rc0-1630-g51cc2e7-nox-fixed -U_FORTIFY_SOURCE -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -Wstrict-prototypes -Wredundant-decls -Wall -Wundef -Wendif-labels -Wwrite-strings -Wmissing-prototypes -fno-strict-aliasing -m32 -DWIN32_LEAN_AND_MEAN -DWINVER=0x501 -MMD -MP -MT audio/mixeng.o -O2 -g -c -o audio/mixeng.o audio/mixeng.c gcc -I/home/sh/vm/qemu/v0.11.0-rc0-1630-g51cc2e7-nox-fixed/slirp -Wold-style-definition -I. -I/home/sh/vm/qemu/v0.11.0-rc0-1630-g51cc2e7-nox-fixed -U_FORTIFY_SOURCE -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -Wstrict-prototypes -Wredundant-decls -Wall -Wundef -Wendif-labels -Wwrite-strings -Wmissing-prototypes -fno-strict-aliasing -m32 -DWIN32_LEAN_AND_MEAN -DWINVER=0x501 -MMD -MP -MT -I/mingw/include/SDL -D_GNU_SOURCE=1 -Dmain=SDL_main -O2 -g -c -o audio/sdlaudio.o audio/sdlaudio.c gcc -I/home/sh/vm/qemu/v0.11.0-rc0-1630-g51cc2e7-nox-fixed/slirp -Wold-style-definition -I. -I/home/sh/vm/qemu/v0.11.0-rc0-1630-g51cc2e7-nox-fixed -U_FORTIFY_SOURCE -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -Wstrict-prototypes -Wredundant-decls -Wall -Wundef -Wendif-labels -Wwrite-strings -Wmissing-prototypes -fno-strict-aliasing -m32 -DWIN32_LEAN_AND_MEAN -DWINVER=0x501 -MMD -MP -MT audio/winwaveaudio.o -O2 -g -c -o audio/winwaveaudio.o audio/winwaveaudio.c The only difference i notice are more spaces: -MMD -MP -MT -I/mingw/include/SDL vs. -MMD -MP -MT -I/mingw/include/SDL - Sebastian