All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lucas Seiki Oshiro <lucasseikioshiro@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Elijah Newren <newren@gmail.com>
Subject: Re: [GSoC][PATCH v3] merge-strategies.adoc: detail submodule merge
Date: Wed, 26 Feb 2025 19:09:53 -0300	[thread overview]
Message-ID: <FD1CBE9F-918A-4056-89D2-832CD07CC73C@gmail.com> (raw)
In-Reply-To: <xmqqr03lkhwl.fsf@gitster.g>


> Should the blank line be added above '+'?  I somehow doubt it.

To be honest, this is my first time using asciidoctor, I 
sincerely don't know. Building a local pdf with
`asciidoctor-pdf` didn't change the generated PDF. But of 
course, this doesn't follow the style of the rest of the
document. I'm sorry, I'll fix it in v4.

> Other than that, looking very good.

Thanks for your help in this patch!


      reply	other threads:[~2025-02-26 22:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-25 16:18 [GSoC][PATCH v3] merge-strategies.adoc: detail submodule merge Lucas Seiki Oshiro
2025-02-25 18:18 ` Junio C Hamano
2025-02-26 22:09   ` Lucas Seiki Oshiro [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=FD1CBE9F-918A-4056-89D2-832CD07CC73C@gmail.com \
    --to=lucasseikioshiro@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=newren@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.