From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 268F8C433E0 for ; Fri, 29 Jan 2021 17:25:29 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 83BBF64E00 for ; Fri, 29 Jan 2021 17:25:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 83BBF64E00 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 96ADD1654; Fri, 29 Jan 2021 18:24:36 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 96ADD1654 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1611941126; bh=IZ8Su8374x8/2Bt9F0RArPF4ZIV6JsUyPnB4MY0n0vo=; h=Date:From:Subject:To:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=odaefss32nTFYHL8kSgH1nhp4wSBmMc+XfYHLjtkAuzHk9WvEjEreZkwYuwqaSV+A t65T215vkzVck8XNGmRYXUYHp9ulQRxBOVd9avQApx715/piAgKlmoHmO0TPDwwkB8 efis2LdS2ff9t7hFfgM12F7srDvrdklwVIsUsSxM= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id E2F2DF80218; Fri, 29 Jan 2021 18:24:35 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id D6900F80259; Fri, 29 Jan 2021 18:24:33 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 94CB3F800E9 for ; Fri, 29 Jan 2021 18:24:26 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 94CB3F800E9 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="bv1dP1r6" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1611941065; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1tJEDpVaTU2o7pEzEYi/Itw24bwaC7NiGn/22B7qnc4=; b=bv1dP1r6yRx8HvpRiBl5i+lknLWT7YZ1pHsDaSX7hU6Sew/ngFeRVFgKyd1lkPvJP1L9Pm DZ4vNSGWWozd1bGBGAvyEiPoGJo8CMSNwBkttKFJTBU58yzJgEZQ6b+owyryzUIK673q+U cHIQGrL1kG/oyAz4Pt2X63HjFwofiO0= Received: from mail-il1-f197.google.com (mail-il1-f197.google.com [209.85.166.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-327-U8uWu3LGO7qLo_4nz_GDnw-1; Fri, 29 Jan 2021 12:24:24 -0500 X-MC-Unique: U8uWu3LGO7qLo_4nz_GDnw-1 Received: by mail-il1-f197.google.com with SMTP id q11so1635743ild.22 for ; Fri, 29 Jan 2021 09:24:24 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:subject:to:cc:message-id:in-reply-to :references:mime-version; bh=1tJEDpVaTU2o7pEzEYi/Itw24bwaC7NiGn/22B7qnc4=; b=YQy3n1b1pnXS+elZ25tQlublJWEDF1KnDjyZq87QWKuOmTkE6UhDHaozmug675Ieqp KGgChzfU1AgAbfzzeDQSYf1sQ8HCwbRqoDIbHCjb/fGEJQoNhL5aXp9SBqIsSZBBgd/8 DA8iVUNFMlKlnYmbr1MHv8RR0bbuS90rSiDSf+eCcgl474Sao9SHhhniDL53YxSQNW3R f7D6Fi2VldaJxSMsj+ENHUgtzBb7a2FldwJ+6a1D6/kEl1hPg5hnLTe+uoHOEM1vbTLG pv8SfU2wXenUePwtsy/Qp5Fp+r/vJtdogt1/QdHNOdSaMuj0g9VgEsqyECLhBWxxGEf+ HSzg== X-Gm-Message-State: AOAM5325QZHC2mPTiEzX4D2U6MhHJ5AXBYZAcE/gt43I6Kld8rE1cYe6 N32miOxH5SjOwEhfEfCUtHsBxHL57Uo8kFMSrWHMK451sRNwKtwx8vLxpXO4mhTAIstWrtF7Vy3 0YvXM/vTaK+nmitYKZn22+IE= X-Received: by 2002:a05:6638:229b:: with SMTP id y27mr4572017jas.136.1611941063712; Fri, 29 Jan 2021 09:24:23 -0800 (PST) X-Google-Smtp-Source: ABdhPJxBQCa/aQwAwI0WBJb/kQp4EcDUYeQ7uixWQ+zr7FFHIFR0qu+Poa5+gr/i329TB8Xg1vOo1g== X-Received: by 2002:a05:6638:229b:: with SMTP id y27mr4571989jas.136.1611941063408; Fri, 29 Jan 2021 09:24:23 -0800 (PST) Received: from chargestone-cave ([2607:9000:0:57::8e]) by smtp.gmail.com with ESMTPSA id b16sm4761308ile.32.2021.01.29.09.24.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Jan 2021 09:24:22 -0800 (PST) Date: Fri, 29 Jan 2021 11:24:16 -0600 From: Michael Catanzaro Subject: Re: [REGRESSION] "ALSA: HDA: Early Forbid of runtime PM" broke =?UTF-8?Q?my=0D=0A?= laptop's internal audio To: Takashi Iwai Message-Id: In-Reply-To: References: <9ACPNQ.AF32G3OJNPHA3@redhat.com> <8CEPNQ.GAG87LR8RI871@redhat.com> X-Mailer: geary/3.38.1 MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=mcatanzaro@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii; format=flowed Cc: alsa-devel@alsa-project.org, "N, Harshapriya" , linux-kernel@vger.kernel.org, stable@vger.kernel.org, Takashi Iwai , kai.vehmanen@intel.com X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Fri, Jan 29, 2021 at 5:17 pm, Takashi Iwai wrote: > --- a/sound/pci/hda/hda_intel.c > +++ b/sound/pci/hda/hda_intel.c > @@ -2217,8 +2217,6 @@ static const struct snd_pci_quirk > power_save_denylist[] = { > /* https://bugzilla.redhat.com/show_bug.cgi?id=1525104 */ > SND_PCI_QUIRK(0x1043, 0x8733, "Asus Prime X370-Pro", 0), > /* https://bugzilla.redhat.com/show_bug.cgi?id=1525104 */ > - SND_PCI_QUIRK(0x1558, 0x6504, "Clevo W65_67SB", 0), > - /* https://bugzilla.redhat.com/show_bug.cgi?id=1525104 */ > SND_PCI_QUIRK(0x1028, 0x0497, "Dell Precision T3600", 0), > /* https://bugzilla.redhat.com/show_bug.cgi?id=1525104 */ > /* Note the P55A-UD3 and Z87-D3HP share the subsys id for the HDA > dev */ Hi, This patch works fine on my laptop. I have no clue whether that means it's really safe to remove the quirk. I've never noticed any clicking noise myself, but I understand it has been a problem for other System76 laptops. Michael From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1377BC433DB for ; Fri, 29 Jan 2021 17:28:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CE12D64E04 for ; Fri, 29 Jan 2021 17:28:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232495AbhA2R1o (ORCPT ); Fri, 29 Jan 2021 12:27:44 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:54556 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231658AbhA2RZy (ORCPT ); Fri, 29 Jan 2021 12:25:54 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1611941065; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1tJEDpVaTU2o7pEzEYi/Itw24bwaC7NiGn/22B7qnc4=; b=bv1dP1r6yRx8HvpRiBl5i+lknLWT7YZ1pHsDaSX7hU6Sew/ngFeRVFgKyd1lkPvJP1L9Pm DZ4vNSGWWozd1bGBGAvyEiPoGJo8CMSNwBkttKFJTBU58yzJgEZQ6b+owyryzUIK673q+U cHIQGrL1kG/oyAz4Pt2X63HjFwofiO0= Received: from mail-il1-f200.google.com (mail-il1-f200.google.com [209.85.166.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-237-FoqXsFDcPmGG2qidoeVqRQ-1; Fri, 29 Jan 2021 12:24:24 -0500 X-MC-Unique: FoqXsFDcPmGG2qidoeVqRQ-1 Received: by mail-il1-f200.google.com with SMTP id x11so8239703ill.17 for ; Fri, 29 Jan 2021 09:24:24 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:subject:to:cc:message-id:in-reply-to :references:mime-version; bh=1tJEDpVaTU2o7pEzEYi/Itw24bwaC7NiGn/22B7qnc4=; b=Cqw0ce/XjFpo+Dv7/ENdWW6gzgWy3qu2dNmakCQsj4dPrPeDJZPZ14+Xw/u9JEgY0p B3+cneMrVjfHem05micseZmqKoQ907X6JRC4E7WXqxqTfCDu0Re2ZqW8QSZVf8kHbqn8 tiAjL8dmW5dCXQcHU6SfEIC1U1UeuzSmuxpH6pmHwAsD4P0MX5G1pYIyzNM2nDg9ueh1 /ZU2bL3xyTCvaGBCfLXHmWbXhD2Vk8VhRlcARCNZE/rcuD1XwyD8ZO0FKVSZ9s9MoBs8 195CngD21ysys1GE+nd2I/rL1qJzLiC477cPVVOJ1s7gMA7bDRVxp6eDiJ6epHr01ob/ +BNQ== X-Gm-Message-State: AOAM532nbUBTK2yL7mMkZSvee18hNDex2qXqJHBu6zGF54a4vdT7P9EN GvqyLFAOZtzUQ5i1GJxaOrH3Jau/6bhPRojvira4NgbyU0WnLX608BRjuH4f42Ee03c9EZUGA5/ jG2BXUtsk1NpVp92Ad5HrBuk0 X-Received: by 2002:a05:6638:229b:: with SMTP id y27mr4571999jas.136.1611941063553; Fri, 29 Jan 2021 09:24:23 -0800 (PST) X-Google-Smtp-Source: ABdhPJxBQCa/aQwAwI0WBJb/kQp4EcDUYeQ7uixWQ+zr7FFHIFR0qu+Poa5+gr/i329TB8Xg1vOo1g== X-Received: by 2002:a05:6638:229b:: with SMTP id y27mr4571989jas.136.1611941063408; Fri, 29 Jan 2021 09:24:23 -0800 (PST) Received: from chargestone-cave ([2607:9000:0:57::8e]) by smtp.gmail.com with ESMTPSA id b16sm4761308ile.32.2021.01.29.09.24.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Jan 2021 09:24:22 -0800 (PST) Date: Fri, 29 Jan 2021 11:24:16 -0600 From: Michael Catanzaro Subject: Re: [REGRESSION] "ALSA: HDA: Early Forbid of runtime PM" broke =?UTF-8?Q?my=0D=0A?= laptop's internal audio To: Takashi Iwai Cc: "N, Harshapriya" , alsa-devel@alsa-project.org, Jaroslav Kysela , Takashi Iwai , linux-kernel@vger.kernel.org, kai.vehmanen@intel.com, stable@vger.kernel.org Message-Id: In-Reply-To: References: <9ACPNQ.AF32G3OJNPHA3@redhat.com> <8CEPNQ.GAG87LR8RI871@redhat.com> X-Mailer: geary/3.38.1 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 29, 2021 at 5:17 pm, Takashi Iwai wrote: > --- a/sound/pci/hda/hda_intel.c > +++ b/sound/pci/hda/hda_intel.c > @@ -2217,8 +2217,6 @@ static const struct snd_pci_quirk > power_save_denylist[] = { > /* https://bugzilla.redhat.com/show_bug.cgi?id=1525104 */ > SND_PCI_QUIRK(0x1043, 0x8733, "Asus Prime X370-Pro", 0), > /* https://bugzilla.redhat.com/show_bug.cgi?id=1525104 */ > - SND_PCI_QUIRK(0x1558, 0x6504, "Clevo W65_67SB", 0), > - /* https://bugzilla.redhat.com/show_bug.cgi?id=1525104 */ > SND_PCI_QUIRK(0x1028, 0x0497, "Dell Precision T3600", 0), > /* https://bugzilla.redhat.com/show_bug.cgi?id=1525104 */ > /* Note the P55A-UD3 and Z87-D3HP share the subsys id for the HDA > dev */ Hi, This patch works fine on my laptop. I have no clue whether that means it's really safe to remove the quirk. I've never noticed any clicking noise myself, but I understand it has been a problem for other System76 laptops. Michael