All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mikko Perttunen <mperttunen@nvidia.com>
To: devicetree@vger.kernel.org
Cc: "Bartosz Golaszewski" <brgl@kernel.org>,
	"Manivannan Sadhasivam" <mani@kernel.org>,
	"Bjorn Helgaas" <bhelgaas@google.com>,
	"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
	"Krzysztof Wilczyński" <kwilczynski@kernel.org>,
	"Rob Herring" <robh@kernel.org>,
	"Jonathan Hunter" <jonathanh@nvidia.com>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-tegra@vger.kernel.org, devicetree@vger.kernel.org,
	"Thierry Reding" <thierry.reding@kernel.org>
Subject: Re: [PATCH 5/6] arm64: tegra: Add node for the GB10B GPU on Tegra264
Date: Wed, 18 Nov 2026 09:30:59 +0900	[thread overview]
Message-ID: <IOZkShOKS1Cv0Px6mU4F6g@nvidia.com> (raw)
In-Reply-To: <avxBUt6Yo3oKbEZI@orome>

On Tuesday, November 17, 2026 9:17 PM Thierry Reding wrote:
> On Thu, Oct 29, 2026 at 12:32:07PM +0900, Mikko Perttunen wrote:
> > While the integrated GB10B GPU on Tegra264 is on the PCI bus, it
> > requires a BPMP power domain to be enabled or it won't enumerate on the
> > bus. Therefore, describe it and the power domain in the device tree to
> > allow the power domain to be enabled prior to enumeration.
> > 
> > Signed-off-by: Mikko Perttunen <mperttunen@nvidia.com>
> > ---
> >  arch/arm64/boot/dts/nvidia/tegra264.dtsi | 6 ++++++
> >  1 file changed, 6 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/nvidia/tegra264.dtsi b/arch/arm64/boot/dts/nvidia/tegra264.dtsi
> > index 5ab34cd09a3d..4c8b320ecc40 100644
> > --- a/arch/arm64/boot/dts/nvidia/tegra264.dtsi
> > +++ b/arch/arm64/boot/dts/nvidia/tegra264.dtsi
> > @@ -3597,6 +3597,12 @@ pcie@0 {
> >  				#address-cells = <3>;
> >  				#size-cells = <2>;
> >  				ranges;
> > +
> > +				gpu@0 {
> > +					compatible = "pci10de,2b00";
> > +					reg = <0x00010000 0x0 0x0 0x0 0x0>;
> > +					power-domains = <&bpmp TEGRA264_POWER_DOMAIN_GPU>;
> > +				};
> 
> My understanding is that the GPU is the only device on this PCI bus, so
> wouldn't it be simpler to add the power-domains property to the bus' DT
> node? I guess that's just another interpretation of how this hardware
> works, and I like how this power control for PCI devices allows
> individual devices to be turned on before the bus probes (there's a case
> like this on Jetson Nano where Ethernet needs a GPIO pin to be pulled up
> in order to start enumerating on the PCI bus, though I don't remember
> how we ended up solving that, sources don't have any indication of that
> GPIO being permanently set high or something).
> 
> Thierry

The bus itself appears (at least to the point of showing up on lspci and 
kernel logs without any errors) to work fine without the power domain, 
so I thought this the correct way to model the hardware. It seems pretty 
straightforward like this anyway.

Mikko




  reply	other threads:[~2026-11-18  0:36 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-29  3:32 [PATCH 0/6] Tegra264 GB10B boards the bus Mikko Perttunen
2026-10-29  3:32 ` [PATCH 1/6] dt-bindings: PCI: tegra264: Allow the ats-supported property Mikko Perttunen
2026-10-29  3:38   ` sashiko-bot
2026-10-29  3:32 ` [PATCH 2/6] PCI/pwrctrl: Enable pwrctrl for devices powered by a power domain Mikko Perttunen
2026-10-29  3:42   ` sashiko-bot
2026-10-30 11:42   ` Bartosz Golaszewski
2026-10-29  3:32 ` [PATCH 3/6] PCI/pwrctrl: Add the Tegra264 iGPU to the generic match table Mikko Perttunen
2026-10-29  3:41   ` sashiko-bot
2026-10-30 11:43   ` Bartosz Golaszewski
2026-10-29  3:32 ` [PATCH 4/6] PCI: tegra264: Power endpoint devices before enumeration Mikko Perttunen
2026-10-29  3:42   ` sashiko-bot
2026-10-30 11:44   ` Bartosz Golaszewski
2026-10-29  3:32 ` [PATCH 5/6] arm64: tegra: Add node for the GB10B GPU on Tegra264 Mikko Perttunen
2026-10-29  3:41   ` sashiko-bot
2026-11-17 12:17   ` Thierry Reding
2026-11-18  0:30     ` Mikko Perttunen [this message]
2026-10-29  3:32 ` [PATCH 6/6] arm64: tegra: Enable and mark the Tegra264 GPU PCIe controller as ATS supported Mikko Perttunen
2026-10-29  3:42   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=IOZkShOKS1Cv0Px6mU4F6g@nvidia.com \
    --to=mperttunen@nvidia.com \
    --cc=bhelgaas@google.com \
    --cc=brgl@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jonathanh@nvidia.com \
    --cc=krzk+dt@kernel.org \
    --cc=kwilczynski@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=lpieralisi@kernel.org \
    --cc=mani@kernel.org \
    --cc=robh@kernel.org \
    --cc=thierry.reding@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.