From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 820F8C433EF for ; Mon, 22 Nov 2021 10:00:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239021AbhKVKDi convert rfc822-to-8bit (ORCPT ); Mon, 22 Nov 2021 05:03:38 -0500 Received: from aposti.net ([89.234.176.197]:56024 "EHLO aposti.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238875AbhKVKDi (ORCPT ); Mon, 22 Nov 2021 05:03:38 -0500 Date: Mon, 22 Nov 2021 10:00:19 +0000 From: Paul Cercueil Subject: Re: [PATCH 03/15] iio: buffer-dma: Use round_down() instead of rounddown() To: Jonathan Cameron Cc: Alexandru Ardelean , Lars-Peter Clausen , Michael Hennerich , Sumit Semwal , Christian =?iso-8859-1?b?S/ZuaWc=?= , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org Message-Id: In-Reply-To: <20211121140823.6b2922f6@jic23-huawei> References: <20211115141925.60164-1-paul@crapouillou.net> <20211115141925.60164-4-paul@crapouillou.net> <20211121140823.6b2922f6@jic23-huawei> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org Hi Jonathan, Le dim., nov. 21 2021 at 14:08:23 +0000, Jonathan Cameron a écrit : > On Mon, 15 Nov 2021 14:19:13 +0000 > Paul Cercueil wrote: > >> We know that the buffer's alignment will always be a power of two; >> therefore, we can use the faster round_down() macro. >> >> Signed-off-by: Paul Cercueil > *groan*. I don't want to know where the naming of these two came > from but that > is spectacular... > > Anyhow, happy to pick up 1-3 now if you like as all are good cleanup > of > existing code. I think you can pick 2-3 now; I will do some changes to patch [01/15] in the V2. Cheers, -Paul From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 51CE0C43217 for ; Mon, 22 Nov 2021 10:00:34 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2263B6E423; Mon, 22 Nov 2021 10:00:33 +0000 (UTC) Received: from aposti.net (aposti.net [89.234.176.197]) by gabe.freedesktop.org (Postfix) with ESMTPS id 02D0C6E423 for ; Mon, 22 Nov 2021 10:00:31 +0000 (UTC) Date: Mon, 22 Nov 2021 10:00:19 +0000 From: Paul Cercueil Subject: Re: [PATCH 03/15] iio: buffer-dma: Use round_down() instead of rounddown() To: Jonathan Cameron Message-Id: In-Reply-To: <20211121140823.6b2922f6@jic23-huawei> References: <20211115141925.60164-1-paul@crapouillou.net> <20211115141925.60164-4-paul@crapouillou.net> <20211121140823.6b2922f6@jic23-huawei> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Transfer-Encoding: quoted-printable X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michael Hennerich , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Christian =?iso-8859-1?b?S/ZuaWc=?= , linaro-mm-sig@lists.linaro.org, Alexandru Ardelean , linux-media@vger.kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Jonathan, Le dim., nov. 21 2021 at 14:08:23 +0000, Jonathan Cameron=20 a =E9crit : > On Mon, 15 Nov 2021 14:19:13 +0000 > Paul Cercueil wrote: >=20 >> We know that the buffer's alignment will always be a power of two; >> therefore, we can use the faster round_down() macro. >>=20 >> Signed-off-by: Paul Cercueil > *groan*. I don't want to know where the naming of these two came=20 > from but that > is spectacular... >=20 > Anyhow, happy to pick up 1-3 now if you like as all are good cleanup=20 > of > existing code. I think you can pick 2-3 now; I will do some changes to patch [01/15]=20 in the V2. Cheers, -Paul