All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mikko Perttunen <mperttunen@nvidia.com>
To: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Thierry Reding <thierry.reding@kernel.org>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Svyatoslav Ryhel <clamor95@gmail.com>,
	Svyatoslav Ryhel <clamor95@gmail.com>
Cc: devicetree@vger.kernel.org, linux-tegra@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 06/10] ARM: tegra: tf701t: Tune MMC devices
Date: Tue, 28 Jul 2026 21:09:28 +0900	[thread overview]
Message-ID: <L1pGU82wTC69ycdbd3YRJQ@nvidia.com> (raw)
In-Reply-To: <20260721101059.451699-7-clamor95@gmail.com>

On Tuesday, July 21, 2026 7:10 PM Svyatoslav Ryhel wrote:
> Add SDR104 mode to WiFi SDIO and uSD device nodes, remove mmc-ddr-1_8v
> which is eMMC specific and improve their power sequences. The uSD card
> refuses to work reliably with fixed regulator and 1.8V IO supply. Adjust
> configuration to mimic setup proposed by the vendor in the downstream
> kernel. Add HS200 mode support to the eMMC sdmmc device node.
> 
> Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com>
> ---
>  .../boot/dts/nvidia/tegra114-asus-tf701t.dts  | 35 +++++++------------
>  1 file changed, 13 insertions(+), 22 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/nvidia/tegra114-asus-tf701t.dts b/arch/arm/boot/dts/nvidia/tegra114-asus-tf701t.dts
> index 83f8dd84d28a2..3de5c84d5f009 100644
> --- a/arch/arm/boot/dts/nvidia/tegra114-asus-tf701t.dts
> +++ b/arch/arm/boot/dts/nvidia/tegra114-asus-tf701t.dts
> @@ -1645,9 +1645,9 @@ ldo8 {
>  
>  					vddio_usd: ldo9 {
>  						regulator-name = "vddio_usd";
> -						/* min voltage of 1.8v is not stable */
> -						regulator-min-microvolt = <2900000>;
> +						regulator-min-microvolt = <1800000>;
>  						regulator-max-microvolt = <2900000>;
> +						regulator-boot-on;
>  					};
>  
>  					avdd_hdmi: ldoln {
> @@ -2350,9 +2350,9 @@ brcm_wifi_pwrseq: pwrseq-wifi {
>  		clocks = <&tegra_pmc TEGRA_PMC_CLK_BLINK>;
>  		clock-names = "ext_clock";
>  
> -		reset-gpios = <&gpio TEGRA_GPIO(X, 7) GPIO_ACTIVE_LOW>;
> -		post-power-on-delay-ms = <300>;
> -		power-off-delay-us = <300>;
> +		reset-gpios = <&gpio TEGRA_GPIO(CC, 5) GPIO_ACTIVE_LOW>;
> +		post-power-on-delay-ms = <100>;
> +		power-off-delay-us = <100>;
>  	};
>  
>  	/* WiFi */
> @@ -2372,9 +2372,7 @@ mmc@78000000 {
>  		non-removable;
>  
>  		sd-uhs-ddr50;
> -		mmc-ddr-1_8v;
> -
> -		power-gpios = <&gpio TEGRA_GPIO(CC, 5) GPIO_ACTIVE_HIGH>;
> +		sd-uhs-sdr104;
>  
>  		nvidia,default-tap = <0x2>;
>  		nvidia,default-trim = <0x2>;
> @@ -2396,14 +2394,18 @@ wifi@1 {
>  	/* MicroSD card */
>  	mmc@78000400 {
>  		status = "okay";
> -
>  		bus-width = <4>;
> +
>  		cd-gpios = <&gpio TEGRA_GPIO(V, 2) GPIO_ACTIVE_LOW>;
> +		power-gpios = <&gpio TEGRA_GPIO(K, 1) GPIO_ACTIVE_HIGH>;
> +
> +		sd-uhs-ddr50;
> +		sd-uhs-sdr104;
>  
>  		nvidia,default-tap = <0x3>;
>  		nvidia,default-trim = <0x3>;
>  
> -		vmmc-supply = <&vdd_2v9_usd>;
> +		vmmc-supply = <&vcore_emmc>;
>  		vqmmc-supply = <&vddio_usd>;
>  	};
>  
> @@ -2414,6 +2416,7 @@ mmc@78000600 {
>  
>  		non-removable;
>  		mmc-ddr-1_8v;
> +		mmc-hs200-1_8v;
>  
>  		vmmc-supply = <&vcore_emmc>;
>  		vqmmc-supply = <&vdd_1v8_vio>;
> @@ -2608,17 +2611,6 @@ hdmi_5v0_sys: regulator-hdmi {
>  		vin-supply = <&vdd_smps10_out2>;
>  	};
>  
> -	vdd_2v9_usd: regulator-vdd-usd {
> -		compatible = "regulator-fixed";
> -		regulator-name = "vdd_sd_slot";
> -		regulator-min-microvolt = <2900000>;
> -		regulator-max-microvolt = <2900000>;
> -		regulator-boot-on;
> -		gpio = <&gpio TEGRA_GPIO(K, 1) GPIO_ACTIVE_HIGH>;
> -		enable-active-high;
> -		vin-supply = <&vcore_emmc>;
> -	};
> -
>  	vdd_1v8_cam: regulator-cam-vio {
>  		compatible = "regulator-fixed";
>  		regulator-name = "vdd_1v8_cam";
> @@ -2655,7 +2647,6 @@ vdd_3v3_com: regulator-com {
>  		regulator-name = "vdd_3v3_com";
>  		regulator-min-microvolt = <3300000>;
>  		regulator-max-microvolt = <3300000>;
> -		regulator-always-on;
>  		regulator-boot-on;
>  		gpio = <&gpio TEGRA_GPIO(U, 1) GPIO_ACTIVE_HIGH>;
>  		enable-active-high;
> -- 
> 2.53.0
> 
> 

Which vendor BSP are you referencing? The one I have seems to set 
MMC_UHS_MASK_DDR50, but I'm not quite sure what board definitions these 
devices are actually using.




  parent reply	other threads:[~2026-07-28 12:09 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-21 10:10 [PATCH v2 00/10] ARM: tegra: tf701t: Add new features Svyatoslav Ryhel
2026-07-21 10:10 ` [PATCH v2 01/10] ARM: tegra: tf701t: Configure CPU DFLL clock node Svyatoslav Ryhel
2026-07-21 10:10 ` [PATCH v2 02/10] ARM: tegra: tf701t: Add core-supply to PMC node Svyatoslav Ryhel
2026-07-21 10:10 ` [PATCH v2 03/10] ARM: tegra: tf701t: Add MC and EMC timing nodes Svyatoslav Ryhel
2026-07-21 10:31   ` sashiko-bot
2026-07-21 10:10 ` [PATCH v2 04/10] ARM: tegra: tf701t: Remove pin_ prefix from PMIC pinmux Svyatoslav Ryhel
2026-07-21 10:10 ` [PATCH v2 05/10] ARM: tegra: tf701t: Add thermal zones for nct1008 sensor Svyatoslav Ryhel
2026-07-21 10:10 ` [PATCH v2 06/10] ARM: tegra: tf701t: Tune MMC devices Svyatoslav Ryhel
2026-07-21 10:33   ` sashiko-bot
2026-07-28 12:09   ` Mikko Perttunen [this message]
2026-07-28 14:17     ` Svyatoslav Ryhel
2026-07-21 10:10 ` [PATCH v2 07/10] ARM: tegra: tf701t: Fix BCM43341 WiFi/BT chip configuration Svyatoslav Ryhel
2026-07-28 12:13   ` Mikko Perttunen
2026-07-28 14:08     ` Svyatoslav Ryhel
2026-07-21 10:10 ` [PATCH v2 08/10] ARM: tegra: tf701t: Complete power sensor node Svyatoslav Ryhel
2026-07-21 10:10 ` [PATCH v2 09/10] ARM: tegra: tf701t: Configure UART-B line used for GPS Svyatoslav Ryhel
2026-07-21 10:23   ` sashiko-bot
2026-07-21 10:10 ` [PATCH v2 10/10] ARM: tegra: tf701t: Add chosen node Svyatoslav Ryhel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=L1pGU82wTC69ycdbd3YRJQ@nvidia.com \
    --to=mperttunen@nvidia.com \
    --cc=clamor95@gmail.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jonathanh@nvidia.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=thierry.reding@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.