From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3C80DC83F15 for ; Wed, 30 Aug 2023 15:46:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Cc:To :Subject:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=AzTazeVLGu6xcjQTqGvCYvgZ8Rn22YU7GlB+fPFSxL4=; b=wMZlY5+Jy/Wd5c4joCv1Eua6VE qiiG5Y6QmRPp+G9ogbzia+mlYcDD35LFhoP7tPj0A/iE+lAkhYnQczZhVVPnGKGQP/zji0BhadjoV Eby/LjmHabnFoGoL4c7v55JjtxN8+Y2W6vFs0ohOLS2GfLplA1ZTumhXDe0rMGn/U3hFryoMeWBlj tw9WHPb7+4XWz6tjXx1W3Kuz5pPnm2Ynu4usjuOn7coR0Ryu33qAqUot369CQgE5x6fAyZ2cD+B+3 q6NmQCwXind6h5isHj9XxDF9Jsij6B/Ivmxqah8C4I/RQ9A8/CADqNRMWMSYYpw50iDgake0923EH c0pH+brg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qbNO0-00Dmyf-19; Wed, 30 Aug 2023 15:45:40 +0000 Received: from m-r1.th.seeweb.it ([5.144.164.170]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qbNNw-00Dmy8-0M for linux-arm-kernel@lists.infradead.org; Wed, 30 Aug 2023 15:45:38 +0000 Received: from [192.168.2.144] (bband-dyn191.178-41-225.t-com.sk [178.41.225.191]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by m-r1.th.seeweb.it (Postfix) with ESMTPSA id 5A346203A7; Wed, 30 Aug 2023 17:45:27 +0200 (CEST) Date: Wed, 30 Aug 2023 17:45:21 +0200 From: Martin Botka Subject: Re: [PATCH] firmware: smccc: Export both soc_id functions To: Sudeep Holla Cc: Mark Rutland , Lorenzo Pieralisi , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Andre Przywara , Alan Ma , Luke Harrison , Marijn Suijten , AngeloGioacchino Del Regno , Konrad Dybcio , Martin Botka Message-Id: In-Reply-To: <20230830154312.zferm3it7mj4nwsy@bogus> References: <20230830-smccc_export-v1-1-6ecc7661bc94@somainline.org> <20230830154312.zferm3it7mj4nwsy@bogus> X-Mailer: geary/43.0 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230830_084536_325250_EAEA9DD7 X-CRM114-Status: GOOD ( 19.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Got it. Cheers, Martin On Wed, Aug 30 2023 at 04:43:12 PM +01:00:00, Sudeep Holla wrote: > On Wed, Aug 30, 2023 at 04:19:23PM +0200, Martin Botka wrote: >> The patches using this are still WIP but the basic point is that >> H616 has 2 >> die revisions (And those have >> couple of other versions themselves) that require different uV and >> some >> frequencies are blacklisted on those >> versions. >> >> The driver is using these functions to read the revision (Not the >> version. >> It just looked like the logical >> thing to export both and Andre confirmed. We can ofc drop the >> version symbol >> export if need be) and reads >> trough the OPP table and selects the supported frequencies and uV >> for the >> chip its running on :) >> >> I will try to get the cpufreq patches in order in the upcoming days >> and I >> will Cc you in those as well + >> post a link to them in this thread :) >> > > For simplicity, just make this patch part of the series that adds > cpufreq > support on this platform/soc. Cross referencing won't give any more > confidence > that the user is also getting merged at the same time as this patch. > > -- > Regards, > Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA61FC83F17 for ; Wed, 30 Aug 2023 18:54:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243221AbjH3Swd (ORCPT ); Wed, 30 Aug 2023 14:52:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41068 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245627AbjH3Ppd (ORCPT ); Wed, 30 Aug 2023 11:45:33 -0400 Received: from relay03.th.seeweb.it (relay03.th.seeweb.it [5.144.164.164]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BEC55132 for ; Wed, 30 Aug 2023 08:45:30 -0700 (PDT) Received: from [192.168.2.144] (bband-dyn191.178-41-225.t-com.sk [178.41.225.191]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by m-r1.th.seeweb.it (Postfix) with ESMTPSA id 5A346203A7; Wed, 30 Aug 2023 17:45:27 +0200 (CEST) Date: Wed, 30 Aug 2023 17:45:21 +0200 From: Martin Botka Subject: Re: [PATCH] firmware: smccc: Export both soc_id functions To: Sudeep Holla Cc: Mark Rutland , Lorenzo Pieralisi , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Andre Przywara , Alan Ma , Luke Harrison , Marijn Suijten , AngeloGioacchino Del Regno , Konrad Dybcio , Martin Botka Message-Id: In-Reply-To: <20230830154312.zferm3it7mj4nwsy@bogus> References: <20230830-smccc_export-v1-1-6ecc7661bc94@somainline.org> <20230830154312.zferm3it7mj4nwsy@bogus> X-Mailer: geary/43.0 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Got it. Cheers, Martin On Wed, Aug 30 2023 at 04:43:12 PM +01:00:00, Sudeep Holla wrote: > On Wed, Aug 30, 2023 at 04:19:23PM +0200, Martin Botka wrote: >> The patches using this are still WIP but the basic point is that >> H616 has 2 >> die revisions (And those have >> couple of other versions themselves) that require different uV and >> some >> frequencies are blacklisted on those >> versions. >> >> The driver is using these functions to read the revision (Not the >> version. >> It just looked like the logical >> thing to export both and Andre confirmed. We can ofc drop the >> version symbol >> export if need be) and reads >> trough the OPP table and selects the supported frequencies and uV >> for the >> chip its running on :) >> >> I will try to get the cpufreq patches in order in the upcoming days >> and I >> will Cc you in those as well + >> post a link to them in this thread :) >> > > For simplicity, just make this patch part of the series that adds > cpufreq > support on this platform/soc. Cross referencing won't give any more > confidence > that the user is also getting merged at the same time as this patch. > > -- > Regards, > Sudeep