From: Paul Cercueil <paul@crapouillou.net>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] sdl_mixer: add FluidSynth support
Date: Sun, 12 Jul 2020 21:15:21 +0200 [thread overview]
Message-ID: <LTEDDQ.J6DCEMZ3G7E9@crapouillou.net> (raw)
In-Reply-To: <20200712210613.0d8085bc@windsurf.home>
Le dim. 12 juil. 2020 ? 21:06, Thomas Petazzoni
<thomas.petazzoni@bootlin.com> a ?crit :
> On Sun, 12 Jul 2020 19:39:36 +0200
> Paul Cercueil <paul@crapouillou.net> wrote:
>
>> > I've applied both patches, but I've changed a bit how the .mk file
>> > handles the option. After both patches, it looks like this:
>> >
>> > ifeq ($(BR2_PACKAGE_FLUIDSYNTH),y)
>> > SDL_MIXER_DEPENDENCIES += fluidsynth
>> > SDL_MIXER_CONF_OPTS += \
>> > --enable-music-midi \
>> > --enable-music-fluidsynth-midi
>> > SDL_MIXER_HAS_MIDI = YES
>> > endif
>> >
>> > ifeq ($(BR2_PACKAGE_SDL_MIXER_MIDI_TIMIDITY),y)
>> > SDL_MIXER_CONF_OPTS += \
>> > --enable-music-midi \
>> > --enable-music-timidity-midi
>> > SDL_MIXER_HAS_MIDI = YES
>> > endif
>> >
>> > ifneq ($(SDL_MIXER_HAS_MIDI),YES)
>> > SDL_MIXER_CONF_OPTS += --disable-music-midi
>> > endif
>>
>> It won't work then. --enable-music-midi automatically enables
>> --enable-music-{native,fluidsynth,timidity}-midi, so these need to
>> be
>> manually disabled. Otherwise when you enable e.g. Fluidsynth, it
>> will
>> also enable Timidity even though the SDL_MIXER_MIDI_TIMIDITY option
>> is
>> OFF.
>
> So, I guess we need this instead:
>
> ifeq ($(BR2_PACKAGE_FLUIDSYNTH),y)
> SDL_MIXER_DEPENDENCIES += fluidsynth
> SDL_MIXER_CONF_OPTS += --enable-music-fluidsynth-midi
> SDL_MIXER_HAS_MIDI = YES
> else
> SDL_MIXER_CONF_OPTS += --disable-music-fluidsynth-midi
> endif
>
> ifeq ($(BR2_PACKAGE_SDL_MIXER_MIDI_TIMIDITY),y)
> SDL_MIXER_CONF_OPTS += --enable-music-timidity-midi
> SDL_MIXER_HAS_MIDI = YES
> else
> SDL_MIXER_CONF_OPTS += --disable-music-timidity-midi
> endif
>
> ifeq ($(SDL_MIXER_HAS_MIDI),YES)
> SDL_MIXER_CONF_OPTS += --disable-music-midi
> else
> SDL_MIXER_CONF_OPTS += --disable-music-midi
> endif
>
> what do you think ?
That would work.
-Paul
> Thomas
> --
> Thomas Petazzoni, CTO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
prev parent reply other threads:[~2020-07-12 19:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-02 15:25 [Buildroot] [PATCH 1/2] sdl_mixer: add FluidSynth support Paul Cercueil
2020-07-02 15:25 ` [Buildroot] [PATCH 2/2] sdl_mixer: add MIDI support using Timidity Paul Cercueil
2020-07-12 13:56 ` [Buildroot] [PATCH 1/2] sdl_mixer: add FluidSynth support Thomas Petazzoni
2020-07-12 17:39 ` Paul Cercueil
2020-07-12 19:06 ` Thomas Petazzoni
2020-07-12 19:15 ` Paul Cercueil [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=LTEDDQ.J6DCEMZ3G7E9@crapouillou.net \
--to=paul@crapouillou.net \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.