From: ultracoolguy@tutanota.com
To: Pavel Machek <pavel@ucw.cz>
Cc: Dmurphy <dmurphy@ti.com>, Alexander Dahl <post@lespocky.de>,
Marek Behun <kabel@blackhole.sk>,
Linux Kernel <linux-kernel@vger.kernel.org>,
Linux Leds <linux-leds@vger.kernel.org>
Subject: Re: [PATCH] leds: lm3697: Fix out-of-bound access
Date: Mon, 5 Oct 2020 20:29:55 +0200 (CEST) [thread overview]
Message-ID: <MIu0jNf--3-2@tutanota.com> (raw)
In-Reply-To: <20201005173227.GA6431@duo.ucw.cz>
This:
led->num_banks = count;
Has to be below devm_kzalloc. Else, it's NULL.
Oct 5, 2020, 17:32 by pavel@ucw.cz:
> Hi!
>
>> Agh. I added the Signed-off-by in an earlier non-published version of the commit, but forgot to add it back. But that doesn't really excuses me.
>>
>> I attached the (hopefully) final version of this patch. Pavel, I'll send the struct rename separately after I submit this.
>>
>
> Thanks, I applied it with ... some tweaks. I hope I did not break it,
> and would not mind testing.
>
> Best regards,
> Pavel
>
>
> --
> (english) http://www.livejournal.com/~pavelmachek
> (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
>
next prev parent reply other threads:[~2020-10-05 18:29 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-03 13:02 [PATCH] leds: lm3697: Fix out-of-bound access ultracoolguy
2020-10-03 13:56 ` Pavel Machek
2020-10-03 14:43 ` ultracoolguy
2020-10-05 12:13 ` Marek Behun
2020-10-05 13:50 ` Pavel Machek
2020-10-05 13:57 ` ultracoolguy
2020-10-05 14:33 ` Dan Murphy
2020-10-05 14:37 ` Dan Murphy
2020-10-05 14:38 ` ultracoolguy
2020-10-05 14:41 ` Dan Murphy
2020-10-05 15:35 ` ultracoolguy
2020-10-05 16:05 ` Pavel Machek
2020-10-05 16:48 ` Alexander Dahl
2020-10-05 17:14 ` ultracoolguy
2020-10-05 17:32 ` Pavel Machek
2020-10-05 18:29 ` ultracoolguy [this message]
2020-10-05 18:31 ` ultracoolguy
2020-10-05 18:39 ` Pavel Machek
2020-10-05 18:48 ` ultracoolguy
2020-10-06 7:33 ` Marek Behun
2020-10-06 11:59 ` ultracoolguy
2020-10-06 12:21 ` Dan Murphy
2020-10-06 14:41 ` Marek Behun
2020-10-06 14:57 ` Dan Murphy
2020-10-06 15:14 ` Marek Behun
2020-10-06 17:26 ` Pavel Machek
2020-10-05 15:59 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MIu0jNf--3-2@tutanota.com \
--to=ultracoolguy@tutanota.com \
--cc=dmurphy@ti.com \
--cc=kabel@blackhole.sk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=post@lespocky.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.