All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Namsun Ch'o" <namnamc@Safe-mail.net>
To: qemu-devel@nongnu.org
Cc: eduardo.otubo@profitbricks.com
Subject: [Qemu-devel] [PATCH] Add syscalls for -runas and -chroot to the seccomp sandbox
Date: Thu, 1 Oct 2015 00:36:05 -0400	[thread overview]
Message-ID: <N1-fOl1digGhI@Safe-mail.net> (raw)

The seccomp sandbox doesn't whitelist setuid, setgid, or setgroups, which are
needed for -runas to work. It also doesn't whitelist chroot, which is needed
for the -chroot option. Unfortunately, QEMU enables seccomp before it drops
privileges or chroots, so without these whitelisted, -runas and -chroot cause
QEMU to be killed with -sandbox on. This patch adds those syscalls.

Signed-off-by: Namsun Ch'o <namnamc@safe-mail.net>
---
diff --git a/qemu-seccomp.c b/qemu-seccomp.c
index f9de0d3..5cb1809 100644
--- a/qemu-seccomp.c
+++ b/qemu-seccomp.c
@@ -237,7 +237,11 @@ static const struct QemuSeccompSyscall seccomp_whitelist[] = {
     { SCMP_SYS(fadvise64), 240 },
     { SCMP_SYS(inotify_init1), 240 },
     { SCMP_SYS(inotify_add_watch), 240 },
-    { SCMP_SYS(mbind), 240 }
+    { SCMP_SYS(mbind), 240 },
+    { SCMP_SYS(setuid), 240 },
+    { SCMP_SYS(setgid), 240 },
+    { SCMP_SYS(chroot), 240 },
+    { SCMP_SYS(setgroups), 240 }
 };

 int seccomp_start(void)

             reply	other threads:[~2015-10-01  4:36 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-01  4:36 Namsun Ch'o [this message]
2015-10-01 12:06 ` [Qemu-devel] [PATCH] Add syscalls for -runas and -chroot to the seccomp sandbox Markus Armbruster
2015-10-02  8:30   ` Daniel P. Berrange
2015-10-02 10:05     ` Markus Armbruster
2015-10-02 14:08       ` Eduardo Otubo
2015-10-02 14:15         ` Daniel P. Berrange
2015-10-02 15:36           ` Eduardo Otubo
2015-10-08 13:34 ` Eduardo Otubo
  -- strict thread matches above, loose matches on Subject: below --
2015-10-02  0:17 namnamc
2015-10-09  2:09 namnamc
2015-10-09  6:54 ` Markus Armbruster
2015-10-09  7:24   ` Eduardo Otubo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=N1-fOl1digGhI@Safe-mail.net \
    --to=namnamc@safe-mail.net \
    --cc=eduardo.otubo@profitbricks.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.