From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 38B78C25B76 for ; Mon, 3 Jun 2024 19:33:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Subject:References: In-Reply-To:Message-ID:Cc:To:From:Date:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=GwQgaCTf9UyIwPof2PInO+2I/iVCbB5Myj10r4y2pao=; b=v9vZ7W580V3qJ6IeRLiti1HUfA qXt1v5iN3E64cRLKch1bz4u2ooLCNKSblELv/IvmQzQTN9BoFKaGXwkL0xba0DDDIPyMBDrCKNkW8 vjwPUGq+6HgDHN5cUJS5YZe7ZcQ6wlWowONINvrZjLjF3bnQSSOjsF3pSBd+ic50o3T9Pa/C2jMZy DJ72QGZduSLnVK1fzjn4iRfq3lyuKseBOg282KFsi2xM67g7tBmplW5RX4kTeAyLLNwHyFbHVLsQj ytf0GEI20+Q7TDuhqzxy0BNpsZDG1AHY+M40HBpVxKjRfKkyJ3e3Gh1oW55IhbXq1Kf19JCC3EG7Y NKtdDRZg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sEDQw-00000000Ckd-1bNL; Mon, 03 Jun 2024 19:33:30 +0000 Received: from w4.tutanota.de ([81.3.6.165]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sEDQs-00000000CiU-0mly for linux-arm-kernel@lists.infradead.org; Mon, 03 Jun 2024 19:33:28 +0000 Received: from tutadb.w10.tutanota.de (unknown [192.168.1.10]) by w4.tutanota.de (Postfix) with ESMTP id 97FAD106013E; Mon, 3 Jun 2024 19:33:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1717443199; s=s1; d=bens.haus; h=From:From:To:To:Subject:Subject:Content-Description:Content-ID:Content-Type:Content-Type:Content-Transfer-Encoding:Content-Transfer-Encoding:Cc:Cc:Date:Date:In-Reply-To:In-Reply-To:MIME-Version:MIME-Version:Message-ID:Message-ID:Reply-To:References:References:Sender; bh=2FaW7jU8Cx/GwNp4bNE8A3s5T06Tt97CBdNwcgcim9g=; b=HBMnh5vleQlaTPovT+nccD1i9T6GqApnbvH/85UGMyoP4F2Sdm7o21gvPxdQVABI LvYo/WP243sTk4GPHlXaX2yZW0IHtJZFrDkXXTc25AanJcz12qkOg+G7uPhekqgAO3T iaXEA+2pSlJiqsrYTllR06Ue284+L7F8bxe/R5Z8OkOeR4xfN/K5avlZtjfWTZW70U0 kQtkt1tcaO12AcHWWU8J/JEu5m9xZgKqQA3fTD7UQ+bP+aettwgdMI53z9+5NJJ4r3W ihQYQi2+5Fi0Px8VOq9NXQLS/NX35r3fDxprk4M8NN4QsAUSzHr9/mL7hskm++/swOU nLlTdoBEiw== Date: Mon, 3 Jun 2024 21:33:19 +0200 (CEST) From: Ben Schneider To: Andrew Lunn Cc: Benjamin Schneider , Gregory Clement , Sebastian Hesselbarth , Linux Arm Kernel , Linux Kernel Message-ID: In-Reply-To: References: <20240603012804.122215-1-ben@bens.haus> <20240603012804.122215-2-ben@bens.haus> Subject: Re: [PATCH] cpufreq: enable 1200Mhz clock speed for armada-37xx MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240603_123326_465880_165829A8 X-CRM114-Status: GOOD ( 20.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SnVuIDMsIDIwMjQsIDA1OjQ2IGJ5IGFuZHJld0BsdW5uLmNoOgoKPiBUaGUgcHJvYmxlbSBpcywg bW9zdCBzeXN0ZW1zIGRvbid0IGhhdmUgdGhlIG5ldyBib290bG9hZGVyLiBBbmQgc28gaWYKPiB5 b3UgZW5hYmxlIDEuMkdIeiwgdGhleSBhcmUgZ29pbmcgdG8gYmUgdW5zdGFibGUuCj4KQmFzZWQg b24gbXkgdGVzdGluZywgdGhlIEEzNzIwIHdhcyB1bnN0YWJsZSB1c2luZyBhIGJvb3Rsb2FkZXIg YnVpbHQKd2l0aCBNYXJ2ZWxsJ3Mgc291cmNlIHdpdGhvdXQgcmVnYXJkIHRvIGNsb2NrIHNwZWVk IG9yIGZyZXF1ZW5jeSBzY2FsaW5nLgoKVGhhdCBpcywgaXQgZGlkbid0IG1hdHRlciBpZiAxLjJH aHogd2FzIGVuYWJsZWQgb3Igbm90LCBhbmQgaXQgZGlkbid0IG1hdHRlcgppZiBjcHVmcmVxLWR0 IHdhcyBsb2FkZWQgb3Igbm90LCBteSBkZXZpY2VzIHdlcmUgcmVsaWFibHkgY3Jhc2hpbmcgd2hl bgp0cnlpbmcgdG8gdXNlIE1hcnZlbGwncyBzb3VyY2UgaW5zdGVhZCBvZiBHbG9iYWxzY2FsZSdz IGZvciBidWlsZGluZyB0aGUKYm9vdGxvYWRlci4gV2hlbiBJIGR1ZyBpbiB0byBmaW5kIHRoZSBk aWZmZXJlbmNlLCB0aGlzIEREUlBIWSBzZXR0aW5nCndhcyBvbmUgb2YgdHdvIHRoYXQgSSBmb3Vu ZC4gSSBhbHNvIGZvdW5kIHRoYXQgc2V0dGluZyBpdCB0byB0aGUgdmFsdWUgaW4KR2xvYmFsc2Nh bGUncyByZXBvcyByZXN0b3JlZCBzdGFiaWxpdHkgdG8gdGhlIGRldmljZXMuCgpJIHRoZW4gdGVz dGVkIDEuMkdoeiBib290bG9hZGVyIHNwZWVkcyBhcyB3ZWxsIGFzIGZyZXF1ZW5jeSBzY2FsaW5n IGFuZApmb3VuZCB0aGF0IHRoZXkgd29ya2VkIGZpbmUuIEkndmUgYmVlbiBrZWVwaW5nIHRyYWNr IGhlcmU6Cmh0dHBzOi8vZ2l0aHViLmNvbS9ic2NobmVpL2VidS1ib290bG9hZGVyCgo+IFJhdGhl ciB0aGFuIG1ha2luZyB0aGlzIHVuY29uZGl0aW9uYWwsIGkgdGhpbmsgaXQgbmVlZHMgdG8gYmUK PiBjb25kaXRpb25hbCBvbiBrbm93aW5nIHRoZSBib290bG9hZGVyIGhhcyBiZWVuIHVwZ3JhZGVk LiBDb3VsZCB5b3UgYWRkCj4gY29kZSB3aGljaCBsb29rcyBpbiB0aGUgRERSUEhZIGFuZCBzZWUg aWYgMHhDMDAwMTAwNCBoYXMgdGhlIGNvcnJlY3QKPiB2YWx1ZS4gT25seSB0aGVuIGVuYWJsZSB0 aGUgYWRkaXRpb25hbCBjbG9jayBzcGVlZC4KPgpJIHRoaW5rIHRoZXJlIGFyZSB0d28gcG90ZW50 aWFsIGlzc3VlcyB3aXRoIGRvaW5nIHNvbWV0aGluZyBsaWtlIHRoYXQuIEZpcnN0LAp0aGF0IERE UlBIWcKgdmFsdWUgaGFzIGJlZW4gZmxpcHBlZCBiYWNrIGFuZCBmb3J0aC4gVGhlIGNoYW5nZSBJ CnN1Ym1pdHRlZCB0byBNYXJ2ZWxsIGp1c3QgdW5kb2VzIHRoaXMgY2hhbmdlIGZyb20gSmFudWFy eSAyMDIxOgpodHRwczovL2dpdGh1Yi5jb20vTWFydmVsbEVtYmVkZGVkUHJvY2Vzc29ycy9tdi1k ZHItbWFydmVsbC9jb21taXQvYzNhOGQzYzdmZjRiZDQ2MDc3MGIwY2Y2MDFlNTdhNmY3MGNiMTg3 MQpQZXJoYXBzIGl0IHdvdWxkIGJlIE9LIGlmIHRoZSBvbGRlciBjb2RlIGlzIGFsc28gc3RhYmxl LCBidXQgSSBoYXZlbid0CnRlc3RlZCBpdC4KClNlY29uZCwgdGhlIHZhbHVlIHNlZW1zIHRvIGJl IGRlbGliZXJhdGVseSBkaWZmZXJlbnQgZm9yIG90aGVyIG1lbW9yeQpjb25maWd1cmF0aW9ucyAo RERSMykgd2hpY2ggbWFrZXMgdGhlIGNvbmRpdGlvbmFsIGxvZ2ljIG1vcmUgY29tcGxleAppZiBp dCdzIG1lYW50IHRvIHdvcmsgZm9yIGFsbCBBMzdYWCB2YXJpYW50cywgYW5kIEkgZG9uJ3QgaGF2 ZSBvdGhlciB2YXJpYW50cwp0byB0ZXN0LgoKR2l2ZW4gdGhlIGhpc3Rvcnkgb2YgdGhpcyBzZXR0 aW5nIGdldHRpbmcgZmxpcHBlZCBiYWNrIGFuZCBmb3J0aCwgYW5kCmhhdmluZyByZWFkIHRocm91 Z2ggYSBmZXcgb2xkIHRocmVhZHMgb24gdGhpcyBzdWJqZWN0LCBpdCdzIG15IHRoZW9yeQp0aGF0 IHNvbWUgb2YgdGhlIGluc3RhYmlsaXR5IGlzc3VlcyB0aGF0IHdlcmUgYXR0cmlidXRlZCB0byBr ZXJuZWwgZnJlcXVlbmN5CnNjYWxpbmcgYW5kL29yIDEuMkdoeiBhcyBhIHNwZWVkIHdlcmUgbW9y ZSBsaWtlbHkgYXR0cmlidXRhYmxlIHRvIGJhZApib290bG9hZGVycyBhbGwgYWxvbmcuIEkndmUg cmVhY2hlZCBvdXQgdG8gQXJtYmlhbiBhbmQgQXJjaCBjb21tdW5pdGllcwp0byBsZXQgdGhlbSBr bm93IGluIHRoZSBob3BlIG9mIGZpbmRpbmcgb3RoZXIgdXNlcnMgb2YgdGhlc2UgZGV2aWNlcwp0 aGF0IG1pZ2h0IGJlIHdpbGxpbmcgdG8gdGVzdCwgYnV0IGhhdmUgbm90IHJlY2VpdmVkIGFueSBy ZXNwb25zZXMuCgpJdCdzIGFsc28gd29ydGggbm90aW5nIHRoYXQgbXkgZGV2aWNlcyBjYW1lIGZy b20gdGhlIGZhY3Rvcnkgd2l0aCB0aGUKYm9vdGxvYWRlciBjbG9ja2VkIGF0IDgwME1oei4gSSdt IHByZXR0eSBzdXJlIHRoZSBPUyBjYW5ub3Qgc2V0IGEKc3BlZWQgYWJvdmXCoHRoZSBib290bG9h ZGVywqBjbG9jayBzcGVlZC4gQXMgYSByZXN1bHQsIGF0IGxlYXN0IGZvciB0aGUKRVNQUkVTU09i aW4gVWx0cmEsIHRoZSBvbmx5IGRldmljZXMgSSB3b3VsZCBleHBlY3QgdG8gYnJlYWsgYXJlIHRo b3NlCndoZXJlIHVzZXJzIGhhdmUgcHV0IGluIHRoZSB3b3JrIHRvIGJ1aWxkIChvciB0YWtlbiB0 aGUgcmlzayBvZiBmbGFzaGluZykKYSBib290bG9hZGVyIGNsb2NrZWQgYXQgMS4yR2h6LiBXaGVu IHRoZSBrZXJuZWwgZW5jb3VudGVycyBvbmUgb2YKdGhvc2UgZGV2aWNlcyBpdCBjdXJyZW50bHkg ZGlzYWJsZXMgZnJlcXVlbmN5IHNjYWxpbmcgZW50aXJlbHkgKGNwdWZyZXEtZHQKd2lsbCBub3Qg bG9hZCkgbGVhdmluZyB0aGVtIHRvIHJ1biBhdCBmdWxsIHNwZWVkIGNvbnN0YW50bHkuIElmIHRo ZXJlIGFyZQp1c2VycyB3aG8gY2FuJ3Qvd29uJ3QgdXBkYXRlIHRoZWlyIGJvb3Rsb2FkZXIgYW5k IGZvciB3aGljaCBmcmVxdWVuY3kKc2NhbGluZyBpcyB1bnN0YWJsZSwgaXQgc2VlbXMgbGlrZSBp dCB3b3VsZCBtYWtlIG1vcmUgc2Vuc2UgYW5kIGZhY2lsaXRhdGUKZnVydGhlciB0ZXN0aW5nIHRv IHVzZSBrZXJuZWwgY29uZmlnIG9yIHVzZXJzcGFjZSB0b29scyBhcyB0aGUgcGxhY2UgdG8KZGlz YWJsZSBzY2FsaW5nLgoKVGhhbmtzIQoKQmVuCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1h cm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcv bWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from w4.tutanota.de (w4.tutanota.de [81.3.6.165]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B8ABE259C for ; Mon, 3 Jun 2024 19:39:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=81.3.6.165 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717443589; cv=none; b=lZrm9QQZpBoXo+DbTG9zaRTUbQiag1hW2X3kXSYZNAe9ujZndVoSVVOAsva6+vWYmkPX7WFeYjqK/GqR7OteHAmgVKNtWiqGWKwNFqPHsu/P7cRdgfHVm3mothWU5zLF2K5WLQ8t+xOye5YrgQ0TRlyYIPUjKGBOXmOwrr90tMY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717443589; c=relaxed/simple; bh=2FaW7jU8Cx/GwNp4bNE8A3s5T06Tt97CBdNwcgcim9g=; h=Date:From:To:Cc:Message-ID:In-Reply-To:References:Subject: MIME-Version:Content-Type; b=t7m83OE9izfPlWMY8x4vgTwXsHMMeFEYci3AC8fTcW4sVSnfJbyIggIcHfRQugRAE8idP4HvjMG2Y+18EKNtlbFkFgjGvskgG0qVY7Ircbwhpi05pWHGcn3IHbLVXyIAtKR1vpuRArd6JaaTRCCaSAEweXg+DM4pM9GxPm65Chk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=bens.haus; spf=pass smtp.mailfrom=bens.haus; dkim=pass (2048-bit key) header.d=bens.haus header.i=@bens.haus header.b=HBMnh5vl; arc=none smtp.client-ip=81.3.6.165 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=bens.haus Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bens.haus Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bens.haus header.i=@bens.haus header.b="HBMnh5vl" Received: from tutadb.w10.tutanota.de (unknown [192.168.1.10]) by w4.tutanota.de (Postfix) with ESMTP id 97FAD106013E; Mon, 3 Jun 2024 19:33:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1717443199; s=s1; d=bens.haus; h=From:From:To:To:Subject:Subject:Content-Description:Content-ID:Content-Type:Content-Type:Content-Transfer-Encoding:Content-Transfer-Encoding:Cc:Cc:Date:Date:In-Reply-To:In-Reply-To:MIME-Version:MIME-Version:Message-ID:Message-ID:Reply-To:References:References:Sender; bh=2FaW7jU8Cx/GwNp4bNE8A3s5T06Tt97CBdNwcgcim9g=; b=HBMnh5vleQlaTPovT+nccD1i9T6GqApnbvH/85UGMyoP4F2Sdm7o21gvPxdQVABI LvYo/WP243sTk4GPHlXaX2yZW0IHtJZFrDkXXTc25AanJcz12qkOg+G7uPhekqgAO3T iaXEA+2pSlJiqsrYTllR06Ue284+L7F8bxe/R5Z8OkOeR4xfN/K5avlZtjfWTZW70U0 kQtkt1tcaO12AcHWWU8J/JEu5m9xZgKqQA3fTD7UQ+bP+aettwgdMI53z9+5NJJ4r3W ihQYQi2+5Fi0Px8VOq9NXQLS/NX35r3fDxprk4M8NN4QsAUSzHr9/mL7hskm++/swOU nLlTdoBEiw== Date: Mon, 3 Jun 2024 21:33:19 +0200 (CEST) From: Ben Schneider To: Andrew Lunn Cc: Benjamin Schneider , Gregory Clement , Sebastian Hesselbarth , Linux Arm Kernel , Linux Kernel Message-ID: In-Reply-To: References: <20240603012804.122215-1-ben@bens.haus> <20240603012804.122215-2-ben@bens.haus> Subject: Re: [PATCH] cpufreq: enable 1200Mhz clock speed for armada-37xx Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Jun 3, 2024, 05:46 by andrew@lunn.ch: > The problem is, most systems don't have the new bootloader. And so if > you enable 1.2GHz, they are going to be unstable. > Based on my testing, the A3720 was unstable using a bootloader built with Marvell's source without regard to clock speed or frequency scaling. That is, it didn't matter if 1.2Ghz was enabled or not, and it didn't matte= r if cpufreq-dt was loaded or not, my devices were reliably crashing when trying to use Marvell's source instead of Globalscale's for building the bootloader. When I dug in to find the difference, this DDRPHY setting was one of two that I found. I also found that setting it to the value in Globalscale's repos restored stability to the devices. I then tested 1.2Ghz bootloader speeds as well as frequency scaling and found that they worked fine. I've been keeping track here: https://github.com/bschnei/ebu-bootloader > Rather than making this unconditional, i think it needs to be > conditional on knowing the bootloader has been upgraded. Could you add > code which looks in the DDRPHY and see if 0xC0001004 has the correct > value. Only then enable the additional clock speed. > I think there are two potential issues with doing something like that. Firs= t, that DDRPHY=C2=A0value has been flipped back and forth. The change I submitted to Marvell just undoes this change from January 2021: https://github.com/MarvellEmbeddedProcessors/mv-ddr-marvell/commit/c3a8d3c7= ff4bd460770b0cf601e57a6f70cb1871 Perhaps it would be OK if the older code is also stable, but I haven't tested it. Second, the value seems to be deliberately different for other memory configurations (DDR3) which makes the conditional logic more complex if it's meant to work for all A37XX variants, and I don't have other varian= ts to test. Given the history of this setting getting flipped back and forth, and having read through a few old threads on this subject, it's my theory that some of the instability issues that were attributed to kernel frequenc= y scaling and/or 1.2Ghz as a speed were more likely attributable to bad bootloaders all along. I've reached out to Armbian and Arch communities to let them know in the hope of finding other users of these devices that might be willing to test, but have not received any responses. It's also worth noting that my devices came from the factory with the bootloader clocked at 800Mhz. I'm pretty sure the OS cannot set a speed above=C2=A0the bootloader=C2=A0clock speed. As a result, at least for= the ESPRESSObin Ultra, the only devices I would expect to break are those where users have put in the work to build (or taken the risk of flashing) a bootloader clocked at 1.2Ghz. When the kernel encounters one of those devices it currently disables frequency scaling entirely (cpufreq-dt will not load) leaving them to run at full speed constantly. If there are users who can't/won't update their bootloader and for which frequency scaling is unstable, it seems like it would make more sense and facilitate further testing to use kernel config or userspace tools as the place to disable scaling. Thanks! Ben