From: Markus Volk <f_l_k@t-online.de>
To: Richard Purdie <richard.purdie@linuxfoundation.org>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [oe-core][PATCH] gstreamer-vaapi: rename USE_X11 variable
Date: Tue, 06 Dec 2022 00:29:48 +0100 [thread overview]
Message-ID: <OLYFMR.XRLL6VOXMZI4@t-online.de> (raw)
In-Reply-To: <febe3d80e804684b2cd8f1be280bca7193e8ff9c.camel@linuxfoundation.org>
[-- Attachment #1: Type: text/plain, Size: 802 bytes --]
Am Mo, 5. Dez 2022 um 22:30:38 +0000 schrieb Richard Purdie
<richard.purdie@linuxfoundation.org>:
> FWIW I do agree with Alex, we can't afford to carry a patch like this
> ourselves and we should discuss it with upstream as it is presumably
> something they'd want to fix. If they reject it for some reason, that
> is a different discussion.
I agree on this point as well. I marked the patch as inappropriate
because I see some more problems here, such as options that should be
boolean and are defined as strings, or the uppercase variables in
general, most of which at least are common enough to possibly cause
unwanted magic. This patch feels like replacing one hack with another.
True, there would be something to discuss.
I'd have to be in the right mood for this. At least today I'm not.
[-- Attachment #2: Type: text/html, Size: 979 bytes --]
next prev parent reply other threads:[~2022-12-05 23:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-05 20:13 [oe-core][PATCH] gstreamer-vaapi: rename USE_X11 variable Markus Volk
2022-12-05 20:36 ` Alexander Kanavin
2022-12-05 22:29 ` Alexandre Belloni
2022-12-05 22:30 ` Richard Purdie
2022-12-05 23:29 ` Markus Volk [this message]
[not found] ` <172E098AC1FC1CC7.6582@lists.openembedded.org>
2022-12-06 19:45 ` Markus Volk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=OLYFMR.XRLL6VOXMZI4@t-online.de \
--to=f_l_k@t-online.de \
--cc=openembedded-core@lists.openembedded.org \
--cc=richard.purdie@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.