All of lore.kernel.org
 help / color / mirror / Atom feed
From: Trammell Hudson via buildroot <buildroot@buildroot.org>
To: Buildroot <buildroot@buildroot.org>
Subject: [Buildroot] package/mosquitto patch problem with gmake < 4.3
Date: Fri, 24 Oct 2025 20:10:12 +0200 (CEST)	[thread overview]
Message-ID: <OcMPUIl--F-9@trmm.net> (raw)

The 0002-Add-configure-time-check-for-lanl.patch for package/mosquitto seems
to have a compilation problem with older make, such as 4.2.1.  The handling
of # characters in function calls or strings changed in 4.3 to no longer
be treated as make end of line comments.

https://lists.gnu.org/archive/html/info-gnu/2020-01/msg00004.html

* WARNING: Backward-incompatibility!  Number signs (#) appearing inside a macro reference or function invocation  no longer introduce comments and should not be escaped with backslashes:  thus a call such as:    foo := $(shell echo '#')  is legal.  Previously the number sign needed to be escaped, for example:    foo := $(shell echo '\#')  Now this latter will resolve to "\#".  If you want to write makefiles  portable to both versions, assign the number sign to a variable:    H := \#    foo := $(shell echo '$H')  This was claimed to be fixed in 3.81, but wasn't, for some reason.  To detect this change search for 'nocomment' in the .FEATURES variable.

The error occurs when building mosquitto with an older make.
>>> mosquitto 2.0.22 Building
[...]config.mk:322: *** unterminated call to function 'shell': missing ')'.  Stop.
make[1]: *** [package/pkg-generic.mk:273: /data/scratch/build/shairport-pi/buildroot/output/build/mosquitto-2.0.22/.stamp_built] Error 2

The test is:

NEED_LIBANL := $(shell printf '#include <stdlib.h>\n#include <netdb.h>\nint main(){return getaddrinfo_a(0, NULL, 0, NULL);}'| $(CC) -D_GNU_SOURCE -o /dev/null -x c - 2>/dev/null || echo YES)

Is there a minimum make version required?  And if so should the top level
build check for it?


--
Trammell Hudson
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

             reply	other threads:[~2025-10-24 18:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-24 18:10 Trammell Hudson via buildroot [this message]
2025-10-25 18:32 ` [Buildroot] package/mosquitto patch problem with gmake < 4.3 Trammell Hudson via buildroot
2025-12-12  6:58   ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=OcMPUIl--F-9@trmm.net \
    --to=buildroot@buildroot.org \
    --cc=hudson@trmm.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.