From: Ramses <ramses@well-founded.dev>
To: Netdev Bot+sashiko <netdev-bot+sashiko@kernel.org>
Cc: Jv <jv@jvosburgh.net>, Andrew+netdev <andrew+netdev@lunn.ch>,
Davem <davem@davemloft.net>, Kuba <kuba@kernel.org>,
Pabeni <pabeni@redhat.com>, Jbohac <jbohac@suse.cz>,
Edumazet <edumazet@kernel.org>, Netdev <netdev@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Razor <razor@blackwall.org>, Hangbin Liu <hangbin.liu@linux.dev>
Subject: Re: [PATCH net v4 1/2] bonding: fix initial last_rx vs ARP-monitor slack window
Date: Fri, 30 Oct 2026 15:46:01 +0100 (CET) [thread overview]
Message-ID: <P5CGXCc--F-9@well-founded.dev> (raw)
In-Reply-To: <179336101608.3134.1827486120303560891@kernel.org>
> [Severity: Low]
> This isn't a bug, but is "until a real reply arrives" accurate? More than
> ARP replies can move last_rx forward.
Right, with arp_validate=none any received frame updates last_rx. v5
says "until it receives traffic".
> [Severity: Medium]
> This seed uses the arp_interval in effect at enslave time. What happens if
> ARP monitoring is turned on later, or the interval is raised?
That issue already existed before this series. The seed was already
computed from arp_interval at enslave time and is not refreshed when the
ARP monitor starts, from bond_open() or bond_option_arp_interval_set().
This patch does not make it worse. Reseeding the slaves when the monitor
starts touches different code paths, so I would rather do that in a separate
follow-up than grow the current patch series.
pw-bot: cr
next prev parent reply other threads:[~2026-10-30 14:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-28 11:48 [PATCH net v4 0/2] bonding: fix the initial last_rx seed for the ARP monitor Ramses de Norre via B4 Relay
2026-10-28 11:48 ` Ramses de Norre
2026-10-28 11:48 ` [PATCH net v4 1/2] bonding: fix initial last_rx vs ARP-monitor slack window Ramses de Norre via B4 Relay
2026-10-28 11:48 ` Ramses de Norre
2026-10-30 2:59 ` Hangbin Liu
2026-10-30 11:50 ` netdev-bot+sashiko
2026-10-30 14:46 ` Ramses [this message]
2026-10-28 11:48 ` [PATCH net v4 2/2] bonding: give a slave that starts UP a full arp_missed_max window Ramses de Norre via B4 Relay
2026-10-28 11:48 ` Ramses de Norre
2026-10-30 11:50 ` netdev-bot+sashiko
2026-10-30 14:47 ` Ramses
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=P5CGXCc--F-9@well-founded.dev \
--to=ramses@well-founded.dev \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=hangbin.liu@linux.dev \
--cc=jbohac@suse.cz \
--cc=jv@jvosburgh.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev-bot+sashiko@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=razor@blackwall.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.