All of lore.kernel.org
 help / color / mirror / Atom feed
From: servpol@tuta.io
To: Sebastian Reichel <sebastian.reichel@collabora.com>
Cc: "Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Linux Pm" <linux-pm@vger.kernel.org>,
	Devicetree <devicetree@vger.kernel.org>,
	"Linux Kernel" <linux-kernel@vger.kernel.org>,
	"Uwe Kleine-König" <u.kleine-koenig@baylibre.com>
Subject: Re: [PATCH v2 2/2] power: supply: Add GL.iNet GL-E750 MCU battery driver
Date: Thu, 12 Nov 2026 21:24:54 +0100 (CET)	[thread overview]
Message-ID: <P6GQkBA--F-9@tuta.io> (raw)
In-Reply-To: <avEHPVdx0NlX4dhy@venus>

On Mon, Nov 09, 2026 at 12:35:58AM +0100, Sebastian Reichel wrote:
> The Sashiko analysis looks correct:
>
> https://sashiko.dev/#/patchset/20261005-gl-e750-mcu-v1-0-499d2e31f786%40tuta.io

Hi Sebastian,

thanks for looking at it. That link is the review of v1, and both
findings there are addressed in this v2 (see "Changes in v2" in the
cover letter):

- a new message (they all start with '{') now ends the previous one,
  so an event that follows a status reply without a line ending is no
  longer appended to it and lost;
- the poll work no longer clears the receive buffer, neither before the
  request nor on the reply timeout; it only consumes a pending status
  reply, so a partially received event stays in the buffer.

Sashiko's review of v2 reports no regressions:
https://sashiko.dev/#/patchset/20261021-gl-e750-mcu-v2-0-9bd7e7c2e0e1%40tuta.io

If you meant something else in that analysis, please let me know and
I'll address it in v3.

Thanks,
Serv

      reply	other threads:[~2026-11-12 20:24 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-21 19:33 [PATCH v2 0/2] power: supply: Add GL.iNet GL-E750 MCU battery driver Serv Pol
2026-10-21 19:33 ` Serv Pol via B4 Relay
2026-10-21 19:33 ` [PATCH v2 1/2] dt-bindings: power: supply: Add GL.iNet GL-E750 MCU Serv Pol
2026-10-21 19:33   ` Serv Pol via B4 Relay
2026-10-21 19:33 ` [PATCH v2 2/2] power: supply: Add GL.iNet GL-E750 MCU battery driver Serv Pol
2026-10-21 19:33   ` Serv Pol via B4 Relay
2026-11-08 23:35   ` Sebastian Reichel
2026-11-12 20:24     ` servpol [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=P6GQkBA--F-9@tuta.io \
    --to=servpol@tuta.io \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=sebastian.reichel@collabora.com \
    --cc=u.kleine-koenig@baylibre.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.