From: James Morris <jmorris@namei.org>
To: "David P. Quigley" <dpquigl@tycho.nsa.gov>
Cc: selinux@tycho.nsa.gov, labeled-nfs@linux-nfs.org
Subject: Re: [PATCH 1/7] Security: Add inode_{get,set}secid LSM hooks and security helper functions
Date: Wed, 1 Aug 2007 20:17:20 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.64.0708012012580.29184@us.intercode.com.au> (raw)
In-Reply-To: <1185998532157-git-send-email-dpquigl@tycho.nsa.gov>
On Wed, 1 Aug 2007, David P. Quigley wrote:
> + * @inode_getsecid:
> + * Returns secid from @inode;
Probably best to specify that this happens via *secid.
> + * @inode_setsecid:
> + * Set the security structure value of @inode with @sid.
> + * Returns 0 on success.
Except when it returns void :-)
> + void (*inode_getsecid)(struct inode *inode, u32 *secid);
> + void (*inode_setsecid)(struct inode *inode, u32 secid);
> +static inline void security_inode_setsecid(struct inode *inode, u32 sid)
> +{
> + if (unlikely (IS_PRIVATE (inode)))
Please remove the extra spaces.
--
James Morris
<jmorris@namei.org>
--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.
next prev parent reply other threads:[~2007-08-02 3:17 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-01 20:02 [RFC] SENFS: MAC labeling support for NFSv4 David P. Quigley
2007-08-01 20:02 ` [PATCH 1/7] Security: Add inode_{get,set}secid LSM hooks and security helper functions David P. Quigley
2007-08-01 21:01 ` Casey Schaufler
2007-08-02 3:17 ` James Morris [this message]
2007-08-01 20:02 ` [PATCH 2/7] VFS: Add sid field to iattr structure for notify_change David P. Quigley
2007-08-01 21:03 ` Casey Schaufler
2007-08-02 3:21 ` James Morris
2007-08-01 20:02 ` [PATCH 3/7] KConfig: Add KConfig entries for MAC labeled NFS David P. Quigley
2007-08-01 21:08 ` Casey Schaufler
2007-08-02 3:24 ` James Morris
2007-08-01 20:02 ` [PATCH 4/7] Security: Add secctx_to_secid LSM hooks and security helper functions David P. Quigley
2007-08-01 21:11 ` Casey Schaufler
2007-08-01 21:41 ` Paul Moore
2007-08-01 22:14 ` Casey Schaufler
2007-08-01 20:02 ` [PATCH 5/7] NFSv4: Add secid recommended attribute and NFSv4 flags David P. Quigley
2007-08-01 21:18 ` Casey Schaufler
2007-08-01 20:02 ` [PATCH 6/7] NFSv4: Client implementation of MAC Labeling David P. Quigley
2007-08-01 21:29 ` Casey Schaufler
2007-08-01 21:34 ` [Labeled-nfs] " Stephen Smalley
2007-08-01 22:06 ` Casey Schaufler
2007-08-02 3:37 ` James Morris
2007-08-02 13:12 ` Stephen Smalley
2007-08-01 20:02 ` [PATCH 7/7] NFSv4: Server " David P. Quigley
2007-08-01 21:33 ` Casey Schaufler
2007-08-02 13:10 ` Stephen Smalley
2007-08-01 20:55 ` [RFC] SENFS: MAC labeling support for NFSv4 Casey Schaufler
2007-08-01 21:30 ` Stephen Smalley
2007-08-01 21:59 ` Casey Schaufler
2007-08-02 13:19 ` Stephen Smalley
2007-08-02 15:26 ` Casey Schaufler
2007-08-02 15:43 ` Stephen Smalley
2007-08-02 16:36 ` Casey Schaufler
2007-08-02 4:19 ` James Morris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0708012012580.29184@us.intercode.com.au \
--to=jmorris@namei.org \
--cc=dpquigl@tycho.nsa.gov \
--cc=labeled-nfs@linux-nfs.org \
--cc=selinux@tycho.nsa.gov \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.