From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Andy Whitcroft <apw@shadowen.org>,
Randy Dunlap <rdunlap@xenotime.net>,
Joel Schopp <jschopp@austin.ibm.com>
Cc: Linux Kernel Development <linux-kernel@vger.kernel.org>
Subject: checkpatch: ERROR: Does not appear to be a unified-diff format patch
Date: Sat, 13 Oct 2007 14:28:00 +0200 (CEST) [thread overview]
Message-ID: <Pine.LNX.4.64.0710131424470.12088@anakin> (raw)
scripts/checkpatch.pl doesn't seem to like this patch:
$ scripts/checkpatch.pl m68k-export-asm-cachectl-h.diff
ERROR: Does not appear to be a unified-diff format patch
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
$ cat m68k-export-asm-cachectl-h.diff
Subject: m68k: Export cachectl.h
From: Matthew Wilcox <matthew@wil.cx>
libffi in GCC 4.2 needs cachectl.h to do its cache flushing. But we
don't currently export it. I believe this patch should do the trick.
Signed-off-by: Matthew Wilcox <matthew@wil.cx>
---
include/asm-m68k/Kbuild | 1 +
1 file changed, 1 insertion(+)
--- a/include/asm-m68k/Kbuild
+++ b/include/asm-m68k/Kbuild
@@ -1 +1,2 @@
include include/asm-generic/Kbuild.asm
+header-y += cachectl.h
$
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next reply other threads:[~2007-10-13 12:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-13 12:28 Geert Uytterhoeven [this message]
2007-10-13 12:47 ` checkpatch: ERROR: Does not appear to be a unified-diff format patch Adrian Bunk
2007-10-13 12:55 ` Jan Engelhardt
2007-10-13 13:52 ` Adrian Bunk
2007-10-13 14:47 ` Andy Whitcroft
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0710131424470.12088@anakin \
--to=geert@linux-m68k.org \
--cc=apw@shadowen.org \
--cc=jschopp@austin.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@xenotime.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.