From: Guennadi Liakhovetski <g.liakhovetski@pengutronix.de>
To: David Brownell <david-b@pacbell.net>
Cc: linux-kernel@vger.kernel.org, i2c@lm-sensors.org
Subject: Re: [PATCH] Define a NO_GPIO macro to compare against and to use as an invalid GPIO
Date: Sun, 10 Feb 2008 18:59:39 +0100 (CET) [thread overview]
Message-ID: <Pine.LNX.4.64.0802101856460.4417@axis700.grange> (raw)
In-Reply-To: <200802091727.42628.david-b@pacbell.net>
David, you convinced me:-) I'll redo the patch. Just one comment:
On Sat, 9 Feb 2008, David Brownell wrote:
> On Saturday 09 February 2008, Guennadi Liakhovetski wrote:
>
> > And when those platforms share drivers, problems
> > arise. And the simple and efficient NO_IRQ notion, that would fis those
> > problems nicely, cannot seem to establish itself.
>
> Inertia is one of the problems there ... plus, the only
> obvious advantage of "#define NO_IRQ 0" is that it makes
> it easier to be lazy about initialization.
>
> Plus, changing platforms to use that convention means they
> mostly need to adopt an *unnatural* step of mapping from the
> hardware IRQ numbers (which often start at zero, as they do
> on one system I just ssh'd into) to some "logical" ID.
> Even if you believe that's worthwhile, it's work; and it
> could easily break something.
NO_IRQ doesn't have to be 0. Platforms, where 0 is a valid number can use
-1, or 256, or whatever they want:-)
Thanks
Guennadi
---
Guennadi Liakhovetski
prev parent reply other threads:[~2008-02-10 17:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-31 15:26 [PATCH] Define a NO_GPIO macro to compare against and to use as an invalid GPIO Guennadi Liakhovetski
2008-02-07 15:24 ` Guennadi Liakhovetski
2008-02-08 23:43 ` David Brownell
2008-02-10 0:13 ` Guennadi Liakhovetski
[not found] ` <Pine.LNX.4.64.0802100053450.7517-0199iw4Nj15frtckUFj5Ag@public.gmane.org>
2008-02-10 1:27 ` David Brownell
2008-02-10 1:27 ` David Brownell
2008-02-10 17:59 ` Guennadi Liakhovetski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0802101856460.4417@axis700.grange \
--to=g.liakhovetski@pengutronix.de \
--cc=david-b@pacbell.net \
--cc=i2c@lm-sensors.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.