Re: [PATCH][Qemu-devel] Single stepping for PPC broken!

[Marius Groeger <mgroeger@sysgo.com>]

On Mon, 11 Feb 2008, Rob Landley wrote:

> On Thursday 10 January 2008 07:57:50 Marius Groeger wrote:
> > The attached patch fixes the problem, but I have to admit I can't tell
> > for sure if this doesn't break other things (such as qemu's built-in
> > GDB server). Could some QEMU ppc expert please comment on this?
> 
> Looks fine to me, but I don't see it in the git mirror I follow...
> 
> Did anybody notice this patch?

Apparently not :-)

I just checked if it still applies, and it doesn't. Checking why I ran 
into the following strangeness in target-ppc/translate.c:gen_goto_tb() 
which appeared during the TCG migration:

  ..
  if ((tb->pc & TARGET_PAGE_MASK) == (dest & TARGET_PAGE_MASK) &&
     !ctx->singlestep_enabled) {
  ..
  } else {
    gen_set_T1(dest);
#if defined(TARGET_PPC64)
    if (ctx->sf_mode)
      gen_op_b_T1_64();
     else
#endif
      gen_op_b_T1();
    if (ctx->singlestep_enabled)
      gen_op_debug()
  }

It seems to me that the second if (ctx->singlestep_enabled) is 
rendundant.

I'll see if I can find some time to see if the patch is still needed 
and if so, update it to the current HEAD.

Thanks
Marius

-- 
Marius Groeger
SYSGO AG                      Embedded and Real-Time Software
Voice: +49 6136 9948 0                  FAX: +49 6136 9948 10
www.sysgo.com | www.elinos.com | www.osek.de | www.pikeos.com