From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755182AbYICLW6 (ORCPT ); Wed, 3 Sep 2008 07:22:58 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752160AbYICLWt (ORCPT ); Wed, 3 Sep 2008 07:22:49 -0400 Received: from winston.telenet-ops.be ([195.130.137.75]:47652 "EHLO winston.telenet-ops.be" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751098AbYICLWt (ORCPT ); Wed, 3 Sep 2008 07:22:49 -0400 Date: Wed, 3 Sep 2008 13:22:47 +0200 (CEST) From: Geert Uytterhoeven To: Roman Zippel cc: linux-m68k@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [patch 7/8] m68k: Add missing dma_sync_single_range_for_{cpu, device}() In-Reply-To: Message-ID: References: <20080903071542.615137611@mail.of.borg> <20080903071742.932797091@mail.of.borg> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 3 Sep 2008, Geert Uytterhoeven wrote: > On Wed, 3 Sep 2008, Roman Zippel wrote: > > On Wed, 3 Sep 2008, Geert Uytterhoeven wrote: > > > > > Add the missing dma_sync_single_range_for_{cpu,device}(), and remove the bogus > > > `inline' for the non-static function dma_sync_single_for_device(). > > > > It's not bogus, it's a hint to gcc to inline the function into the callers > > in the same file, but also to provide an external version. > > IIRC, gcc actually complained about it. I'll check again... | arch/m68k/include/asm/dma-mapping.h:73: warning: 'dma_sync_single_for_device' declared inline after being called | arch/m68k/include/asm/dma-mapping.h:73: warning: previous declaration of 'dma_sync_single_for_device' was here Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds