All of lore.kernel.org
 help / color / mirror / Atom feed
From: Meelis Roos <mroos@linux.ee>
To: sparclinux@vger.kernel.org
Subject: virt_irq_{alloc,free} inconsistency with no MSI
Date: Fri, 16 Feb 2007 10:30:56 +0000	[thread overview]
Message-ID: <Pine.SOC.4.64.0702161227260.3144@math> (raw)

While investigating this (with current -git for sun4u and no 
CONFIG_PCI_MSI)

  CC      arch/sparc64/kernel/irq.o
cc1: warnings being treated as errors
arch/sparc64/kernel/irq.c:113: warning: 'virt_irq_free' defined but not used

I found that virt_irq_free() is used only if CONFIG_PCI_MSI is defined 
(for sun4v - simple to cure with a define), but virt_irq_alloc() is used 
even without MSI enabled. Is this really correct? Do we alloc and not 
free it in this case?

-- 
Meelis Roos (mroos@linux.ee)

             reply	other threads:[~2007-02-16 10:30 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-16 10:30 Meelis Roos [this message]
2007-02-19  8:31 ` virt_irq_{alloc,free} inconsistency with no MSI David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.SOC.4.64.0702161227260.3144@math \
    --to=mroos@linux.ee \
    --cc=sparclinux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.