All of lore.kernel.org
 help / color / mirror / Atom feed
From: Evalyn Goemer <git@evalyngoemer.com>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Borislav Petkov <bp@alien8.de>,
	dave.hansen@linux.intel.com, ludloff@gmail.com,
	linux-kernel@vger.kernel.org, tglx@kernel.org, mingo@redhat.com,
	x86@kernel.org, joe@perches.com,
	Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH] platform/x86: handle Intel CPUs falsely reporting as GenuineIotel
Date: Sat, 04 Jul 2026 15:23:36 -0400	[thread overview]
Message-ID: <QkeHI624QkWIMyXeKyfLwQ@evalyngoemer.com> (raw)
In-Reply-To: <E4FD4048-9FBE-4316-BFB6-6F5977780571@zytor.com>

On Saturday, July 4, 2026 2:52:14 PM Eastern Daylight Time H. Peter Anvin 
wrote:
> On July 4, 2026 11:29:52 AM PDT, Borislav Petkov <bp@alien8.de> wrote:
> >On Sat, Jul 04, 2026 at 02:15:02PM -0400, Evalyn Goemer wrote:
> >> > Overall, it's an outlier, and I'd flag such systems, not placate them.
> >> 
> >> Yeah it's a very strange thing I have found and thought could be worth
> >> handling. I ended up making the patch this way since this is the only
> >> case of this I could see as well other codebases online handled it
> >> similarly.>
> >Well, Sashiko pointed out a couple more places:
> >
> >https://sashiko.dev/#/patchset/20260704025147.585133-1-git%40evalyngoemer.c
> >om
> >
> >which would need to be taken care of too.
> >
> >But I tend to agree with Christian and even go a step further - completely
> >stop booting on them. Because who knows what else has been tampered with in
> >them.
> >
> >Yeah, yeah, bit flips, sure, but a system which generates bit flips
> >reliably gets its DRAM replaced so why should we treat this thing
> >differently...
> >
> >Let's see what Intel folks say here too.
> 
> To tell you the truth this is literally the first time I have heard of this
> at all!
> 
> At the very least we should taint these as CPU_OUT_OF_SPEC. It doesn't seem
> like a bad idea either to halt *by default*.
> 
> I would like to see a command line option to override that behavior, though.
> Heck, an x86.cpu_vendor=<string> command line option might be useful for
> debugging in general.

This does seem like a better solution. Would adding a fallback check here in 
arch/x86/kernel/cpu/common.c for the get_cpu_vendor() function before the 
generic error to halt the CPU or if  x86.cpu_vendor.bypass_iotel is set or 
something similar proceed to taint the CPU, log an specific warning but still 
report as an Intel for other code.

If it is by default a halt/panic it may also not need checks in the low level 
code and KVM code mentioned by Sashiko since they are relatively minor and 
needs an explicit bypass to boot on a CPU that is known to be tainted 
regardless.

Do let me know if there is a more proper place for this kind of check but I 
would be glad to make a patch to handle this in such a way since yeah such 
CPUs could have some other worse issues.

What do you think x86.cpu_vendor=<string> should do? My mind is coming up 
blank on this. If this is for emulating specific vendor strings it could be 
done at the hypervisor level for testing.




  reply	other threads:[~2026-07-04 19:23 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-04  8:22 [PATCH] platform/x86: handle Intel CPUs falsely reporting as GenuineIotel Christian Ludloff
2026-07-04  9:46 ` Evalyn Goemer
2026-07-04 17:00   ` Christian Ludloff
2026-07-04 18:15     ` Evalyn Goemer
2026-07-04 18:29       ` Borislav Petkov
2026-07-04 18:52         ` H. Peter Anvin
2026-07-04 19:23           ` Evalyn Goemer [this message]
2026-07-04 19:39       ` Christian Ludloff
  -- strict thread matches above, loose matches on Subject: below --
2026-07-04  2:51 git
2026-07-04  8:37 ` David Laight

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=QkeHI624QkWIMyXeKyfLwQ@evalyngoemer.com \
    --to=git@evalyngoemer.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ludloff@gmail.com \
    --cc=mingo@redhat.com \
    --cc=tglx@kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.