From: Paul Grandperrin <paul.grandperrin@gmail.com>
To: gregkh@linuxfoundation.org
Cc: Ricky WU <ricky_wu@realtek.com>,
arnd@arndb.de, linux-kernel@vger.kernel.org,
Jade Lovelace <lists@jade.fyi>
Subject: Re: [PATCH] misc: rtsx: Fix some platforms can not boot and move the l1ss judgment to probe
Date: Wed, 20 Sep 2023 14:47:15 +0200 [thread overview]
Message-ID: <RIBA1S.HYP1X2RG9UAF3@gmail.com> (raw)
In-Reply-To: <2023092032-blurred-upload-30bd@gregkh>
Hi Greg and Ricky,
I just finished testing the patch (on top of 6.1.53) and AFAICT it's
working perfectly:
- system boots and all hardware devices seems to work fine
- nothing weird in kernel and system logs
- suspend-to-ram (S3) works
- the SD card reader works
If there's anything more you want me to test, don't hesitate.
Paul
On Wed, Sep 20 2023 at 11:21:13 +02:00:00, gregkh@linuxfoundation.org
wrote:
> On Wed, Sep 20, 2023 at 09:11:19AM +0000, Ricky WU wrote:
>> commit 101bd907b424 ("misc: rtsx: judge ASPM Mode to set PETXCFG
>> Reg")
>> some readers no longer force #CLKREQ to low
>> when the system need to enter ASPM.
>> But some platform maybe not implement complete ASPM?
>> it causes some platforms can not boot
>>
>> Like in the past only the platform support L1ss we release the
>> #CLKREQ.
>> Move the judgment (L1ss) to probe,
>> we think read config space one time when the driver start is enough
>>
>> Fixes: 101bd907b424 ("misc: rtsx: judge ASPM Mode to set PETXCFG
>> Reg")
>> Signed-off-by: Ricky Wu <ricky_wu@realtek.com>
>
> What about all of the people that reported this issue? Have they been
> able to test it? At least a reported-by line should be added, right?
>
> And I'd like someone to test it to verify it fixes the issue before
> applying it...
>
> thanks,
>
> greg k-h
next prev parent reply other threads:[~2023-09-20 12:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-20 9:11 [PATCH] misc: rtsx: Fix some platforms can not boot and move the l1ss judgment to probe Ricky WU
2023-09-20 9:21 ` gregkh
2023-09-20 12:47 ` Paul Grandperrin [this message]
2023-09-20 13:06 ` Greg KH
2023-09-24 21:05 ` Jade Lovelace
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=RIBA1S.HYP1X2RG9UAF3@gmail.com \
--to=paul.grandperrin@gmail.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lists@jade.fyi \
--cc=ricky_wu@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.