From: Hamza Mahfooz <someguy@effective-light.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: git@vger.kernel.org, "Junio C Hamano" <gitster@pobox.com>,
"Carlo Marcelo Arenas Belón" <carenas@gmail.com>,
"René Scharfe" <l.s.r@web.de>,
"Andreas Schwab" <schwab@linux-m68k.org>
Subject: Re: [PATCH 2/2] ci: add a job for PCRE2
Date: Mon, 22 Nov 2021 17:26:51 -0500 [thread overview]
Message-ID: <ROVZ2R.2MLACYZXFLRU@effective-light.com> (raw)
In-Reply-To: <211118.86h7c96885.gmgdl@evledraar.gmail.com>
On Thu, Nov 18 2021 at 11:32:50 AM +0100, Ævar Arnfjörð Bjarmason
<avarab@gmail.com> wrote:
>>
> Thanks a lot for following-up on this. Do you have a link to a sample
> run of this to see how it looks?
https://github.com/effective-light/git/actions/runs/1492352516
(it looks like the disable unicode case isn't worth considering, since
it never runs through the tests successfully).
> But on closer inspection I should have said
> --{enable,disable}-unicode. Eyeballing the configure.ac in pcre2.git
> now
> and checking if/how it passes our tests I think it might be a noop
> unless --enable-ebcdic is also in play, which we don't need to test.
Looks like ebcdic and unicode can't be enabled at the same time.
> Any reason for picking those specific versions? I think we do need to
> test on older than 10.31 (released in early 2018).
I chose them primarily because they were brought up on the other thread.
next prev parent reply other threads:[~2021-11-22 22:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-18 8:41 [PATCH 1/2] grep/pcre2: limit the instances in which UTF mode is enabled Hamza Mahfooz
2021-11-18 8:41 ` [PATCH 2/2] ci: add a job for PCRE2 Hamza Mahfooz
2021-11-18 9:53 ` [PATCH v2 " Hamza Mahfooz
2021-11-18 10:32 ` [PATCH " Ævar Arnfjörð Bjarmason
2021-11-22 22:26 ` Hamza Mahfooz [this message]
2021-11-18 10:04 ` [PATCH 1/2] grep/pcre2: limit the instances in which UTF mode is enabled Carlo Arenas
2021-11-18 19:40 ` Carlo Marcelo Arenas Belón
2021-11-18 20:53 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ROVZ2R.2MLACYZXFLRU@effective-light.com \
--to=someguy@effective-light.com \
--cc=avarab@gmail.com \
--cc=carenas@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=l.s.r@web.de \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.