From: Paul Cercueil <paul@crapouillou.net>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] system: set default PATH according to BR2_ROOTFS_MERGED_USR
Date: Fri, 14 Aug 2020 14:00:27 +0200 [thread overview]
Message-ID: <ROY1FQ.JZN208FBCKPR@crapouillou.net> (raw)
In-Reply-To: <20200813213802.GM13263@scaer>
Hi Yann,
Le jeu. 13 ao?t 2020 ? 23:38, Yann E. MORIN <yann.morin.1998@free.fr>
a ?crit :
> Paul, All,
>
> On 2020-08-08 17:55 +0200, Paul Cercueil spake thusly:
>> Use "/usr/bin:/usr/sbin" as the default path if
>> BR2_ROOTFS_MERGED_USR
>> is enabled, otherwise use "/bin:/sbin:/usr/bin:/usr/sbin".
>
> Why? Is it fixing an issue, or is it just for the beauty of it?
I got a PR to remove /bin:/sbin from the BR2_SYSTEM_DEFAULT_PATH in my
tree, I thought it made more sense to do it this way.
Cheers,
-Paul
> However, see below...
>
>> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
>> ---
>> system/Config.in | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/system/Config.in b/system/Config.in
>> index 5063797976..b8b7c16529 100644
>> --- a/system/Config.in
>> +++ b/system/Config.in
>> @@ -402,7 +402,8 @@ endif # BR2_ROOTFS_SKELETON_DEFAULT
>>
>> config BR2_SYSTEM_DEFAULT_PATH
>> string "Set the system's default PATH"
>> - default "/bin:/sbin:/usr/bin:/usr/sbin"
>
> This default is a bit unfortunate. Traditionally, distributions have a
> default set to /usr/sbin:/usr/bin:/sbin:/bin (i.e. exactly the reverse
> order that we have).
>
> However, we have that to keep the behaviour prior to 375f7488758.
>
>> + default "/usr/bin:/usr/sbin" if BR2_ROOTFS_MERGED_USR
>> + default "/bin:/sbin:/usr/bin:/usr/sbin" if !BR2_ROOTFS_MERGED_USR
>
> I have no strong opinion, but I wonder why you had to do that...
>
> Regards,
> Yann E. MORIN.
>
>> help
>> Sets the system's default PATH. It is being used in
>> /etc/profile in the skeleton-init-common package and by some
>> --
>> 2.28.0
>>
>> _______________________________________________
>> buildroot mailing list
>> buildroot at busybox.net
>> http://lists.busybox.net/mailman/listinfo/buildroot
>
> --
> .-----------------.--------------------.------------------.--------------------.
> | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics'
> conspiracy: |
> | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___
> |
> | +33 561 099 427 `------------.-------: X AGAINST | \e/
> There is no |
> | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v
> conspiracy. |
> '------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2020-08-14 12:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-08 15:55 [Buildroot] [PATCH] system: set default PATH according to BR2_ROOTFS_MERGED_USR Paul Cercueil
2020-08-13 21:38 ` Yann E. MORIN
2020-08-14 12:00 ` Paul Cercueil [this message]
2020-08-16 22:16 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ROY1FQ.JZN208FBCKPR@crapouillou.net \
--to=paul@crapouillou.net \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.