From: Andries.Brouwer@cwi.nl
To: axboe@suse.de, torvalds@transmeta.com
Cc: alan@lxorguk.ukuu.org.uk, andre@linux-ide.org,
linux-kernel@vger.kernel.org, p_gortmaker@yahoo.com
Subject: Re: [PATCH] off-by-1 error in ide-probe (2.4.x)
Date: Mon, 19 Mar 2001 01:18:30 +0100 (MET) [thread overview]
Message-ID: <UTC200103190018.BAA09516.aeb@vlet.cwi.nl> (raw)
On Sun, 18 Mar 2001, Jens Axboe wrote:
>
> The 256 is _not_ a bug in the driver, it's more likely a bug in your
> drive. 256 is a perfectly legal transfer size. That said, maybe it is
> a good idea to leave it at 255 just for safety on drives not handling
> 0 sectors == 128kB transfer.
Agreed. That would be a trivially easy bug in the firmware, limiting to
255 sectors seems safer.
Linus
Yes, possibly.
I checked old standards, and see that "0 means 256 as a sector count"
is already in ATA-1.
Is there any evidence that other people have been hit by this?
Unfortunately, the
"status error: status=0x58 { DriveReady SeekComplete DataRequest }"
is reported frequently these days, and has many causes.
In old reports it is rare. (E.g. none in lk for 1997.)
Paul: is there only one disk that you can make fail this way?
Andries
next reply other threads:[~2001-03-19 0:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-03-19 0:18 Andries.Brouwer [this message]
2001-03-19 1:24 ` [PATCH] off-by-1 error in ide-probe (2.4.x) Linus Torvalds
2001-03-19 2:23 ` Andre Hedrick
-- strict thread matches above, loose matches on Subject: below --
2001-03-18 9:19 Paul Gortmaker
2001-03-18 21:35 ` Jens Axboe
2001-03-18 23:27 ` Linus Torvalds
2001-03-18 23:32 ` Andre Hedrick
2001-03-22 9:26 ` Paul Gortmaker
2001-03-22 13:32 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=UTC200103190018.BAA09516.aeb@vlet.cwi.nl \
--to=andries.brouwer@cwi.nl \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=andre@linux-ide.org \
--cc=axboe@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=p_gortmaker@yahoo.com \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.