From: Andries.Brouwer@cwi.nl
To: jgarzik@mandrakesoft.com, linux-kernel@vger.kernel.org,
torvalds@transmeta.com
Cc: viro@math.psu.edu
Subject: Re: PATCH 2.5.2.6: fix up serial, sysrq
Date: Thu, 3 Jan 2002 02:36:26 GMT [thread overview]
Message-ID: <UTC200201030236.CAA194545.aeb@cwi.nl> (raw)
From: Jeff Garzik <jgarzik@mandrakesoft.com>
The kdev_none change might not be correct, please check.
Indeed, I would say it is not.
- if (!is_local_disk(sb->s_dev) && MAJOR(sb->s_dev))
+ if (!is_local_disk(sb->s_dev) && !kdev_none(sb->s_dev))
go_sync(sb, remount_flag);
Without studying the surrounding code, I conjecture that
the test MAJOR(sb->s_dev) was meant to exclude anonymous
devices (with major 0), not only NODEV.
Andries
next reply other threads:[~2002-01-03 2:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-01-03 2:36 Andries.Brouwer [this message]
-- strict thread matches above, loose matches on Subject: below --
2002-01-01 23:36 PATCH 2.5.2.6: fix up serial, sysrq Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=UTC200201030236.CAA194545.aeb@cwi.nl \
--to=andries.brouwer@cwi.nl \
--cc=jgarzik@mandrakesoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
--cc=viro@math.psu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.