From: kristofferhaugsbakk@fastmail.com
To: git@vger.kernel.org
Cc: Kristoffer Haugsbakk <code@khaugsbakk.name>,
Patrick Steinhardt <ps@pks.im>
Subject: [PATCH v2 3/5] SubmittingPatches: document Based-on-patch-by trailer
Date: Wed, 17 Jun 2026 22:52:17 +0200 [thread overview]
Message-ID: <V2_Based-on-patch-by.9b9@msgid.xyz> (raw)
In-Reply-To: <V2_CV_SubPatches_trailers.9b6@msgid.xyz>
From: Kristoffer Haugsbakk <code@khaugsbakk.name>
This trailer comes up often enough and the use case is not fully covered
by the other trailers here. For example, it is sometimes better to use
this trailer instead of `Co-authored-by:`.
Signed-off-by: Kristoffer Haugsbakk <code@khaugsbakk.name>
---
Notes (series):
v2:
• Do *not* say *without sign-off*; do mention the precondition that
it is signed off, and cover the case when the patch author did not
sign off on it
• https://lore.kernel.org/git/xmqqse6tnho1.fsf@gitster.g/
• Drop “without a commit message”. It doesn’t seem important. A bare
patch is just a patch, not a patch plus a message.
Documentation/SubmittingPatches | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches
index 38e18982aa2..4a37bc29f5a 100644
--- a/Documentation/SubmittingPatches
+++ b/Documentation/SubmittingPatches
@@ -465,6 +465,10 @@ These are the common trailers in use:
and found it to have the desired effect.
. `Co-authored-by:` is used to indicate that people exchanged drafts
of a patch before submitting it.
+. `Based-on-patch-by:` is used when someone else authored parts of the
+ patch that you are submitting. This might be relevant if someone sent
+ a patch to the mailing list with their sign-off. (Be mindful and ask
+ them to sign off on it if they did not.)
. `Helped-by:` is used to credit someone who suggested ideas for
changes without providing the precise changes in patch form.
. `Mentored-by:` is used to credit someone with helping develop a
--
2.54.0.22.g9e26862b904
next prev parent reply other threads:[~2026-06-17 20:53 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-10 22:22 [PATCH 0/6] SubmittingPatches: update and flesh out trailer sections kristofferhaugsbakk
2026-06-10 22:22 ` [PATCH 1/6] SubmittingPatches: encourage trailer use for substantial help kristofferhaugsbakk
2026-06-11 16:44 ` Junio C Hamano
2026-06-16 20:14 ` Kristoffer Haugsbakk
2026-06-10 22:22 ` [PATCH 2/6] SubmittingPatches: discuss non-ident trailers kristofferhaugsbakk
2026-06-12 11:35 ` Patrick Steinhardt
2026-06-16 20:02 ` Kristoffer Haugsbakk
2026-06-17 7:32 ` Patrick Steinhardt
2026-06-17 19:43 ` Kristoffer Haugsbakk
2026-06-10 22:22 ` [PATCH 3/6] SubmittingPatches: discourage common Linux trailers kristofferhaugsbakk
2026-06-11 16:46 ` Junio C Hamano
2026-06-10 22:22 ` [PATCH 4/6] SubmittingPatches: document Based-on-patch-by trailer kristofferhaugsbakk
2026-06-11 16:52 ` Junio C Hamano
2026-06-16 20:07 ` Kristoffer Haugsbakk
2026-06-10 22:22 ` [PATCH 5/6] SubmittingPatches: be consistent with trailer markup kristofferhaugsbakk
2026-06-10 22:22 ` [PATCH 6/6] SubmittingPatches: note that trailer order matters kristofferhaugsbakk
2026-06-10 22:30 ` Junio C Hamano
2026-06-16 20:18 ` Kristoffer Haugsbakk
2026-06-17 20:52 ` [PATCH v2 0/5] SubmittingPatches: update and flesh out trailer sections kristofferhaugsbakk
2026-06-17 20:52 ` [PATCH v2 1/5] SubmittingPatches: encourage trailer use for substantial help kristofferhaugsbakk
2026-06-17 21:41 ` Junio C Hamano
2026-06-17 20:52 ` [PATCH v2 2/5] SubmittingPatches: discourage common Linux trailers kristofferhaugsbakk
2026-06-17 20:52 ` kristofferhaugsbakk [this message]
2026-06-17 20:52 ` [PATCH v2 4/5] SubmittingPatches: be consistent with trailer markup kristofferhaugsbakk
2026-06-17 20:52 ` [PATCH v2 5/5] SubmittingPatches: note that trailer order matters kristofferhaugsbakk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=V2_Based-on-patch-by.9b9@msgid.xyz \
--to=kristofferhaugsbakk@fastmail.com \
--cc=code@khaugsbakk.name \
--cc=git@vger.kernel.org \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.