All of lore.kernel.org
 help / color / mirror / Atom feed
From: kristofferhaugsbakk@fastmail.com
To: git@vger.kernel.org
Cc: Kristoffer Haugsbakk <code@khaugsbakk.name>,
	Derrick Stolee <stolee@gmail.com>
Subject: [PATCH v2] doc: add caveat about turning off commit-graph
Date: Thu,  7 May 2026 20:20:55 +0200	[thread overview]
Message-ID: <V2_caveat_commit-graph.68b@msgid.xyz> (raw)
In-Reply-To: <caveat_commit-graph.671@msgid.xyz>

From: Kristoffer Haugsbakk <code@khaugsbakk.name>

The doc `technical/commit-graph.adoc` says that replace objects and
commit grafts turn off commit-graph:

    Commit grafts and replace objects can change the shape of the commit
    history. The latter can also be enabled/disabled on the fly using
    `--no-replace-objects`. This leads to difficulty storing both possible
    interpretations of a commit id, especially when computing generation
    numbers. The commit-graph will not be read or written when
    replace-objects or grafts are present.

But this isn’t mentioned in the user-facing doc. Let’s mention it on
git-replace(1) and git-commit-graph(1).

Signed-off-by: Kristoffer Haugsbakk <code@khaugsbakk.name>
---

Notes (series):
    v2: Incorporate “performance issues” suggestion on git-replace(1)

 Documentation/git-commit-graph.adoc | 6 ++++++
 Documentation/git-replace.adoc      | 7 +++++++
 2 files changed, 13 insertions(+)

diff --git a/Documentation/git-commit-graph.adoc b/Documentation/git-commit-graph.adoc
index 6d19026035f..f2a37e91634 100644
--- a/Documentation/git-commit-graph.adoc
+++ b/Documentation/git-commit-graph.adoc
@@ -146,6 +146,12 @@ $ git show-ref -s | git commit-graph write --stdin-commits
 $ git rev-parse HEAD | git commit-graph write --stdin-commits --append
 ------------------------------------------------
 
+CAVEATS
+-------
+
+The existence of replace objects or commit grafts turns off reading or
+writing to the commit-graph. See linkgit:git-replace[1].
+
 CONFIGURATION
 -------------
 
diff --git a/Documentation/git-replace.adoc b/Documentation/git-replace.adoc
index 0a65460adbd..436a0e58caf 100644
--- a/Documentation/git-replace.adoc
+++ b/Documentation/git-replace.adoc
@@ -145,6 +145,13 @@ commit instead of the replaced commit.
 There may be other problems when using 'git rev-list' related to
 pending objects.
 
+CAVEATS
+-------
+
+The existence of replace objects or commit grafts turns off reading or
+writing to the commit-graph, which can cause performance issues. See
+linkgit:git-commit-graph[1].
+
 SEE ALSO
 --------
 linkgit:git-hash-object[1]

Interdiff against v1:
  diff --git a/Documentation/git-replace.adoc b/Documentation/git-replace.adoc
  index 2c0ea07724d..436a0e58caf 100644
  --- a/Documentation/git-replace.adoc
  +++ b/Documentation/git-replace.adoc
  @@ -149,7 +149,8 @@ CAVEATS
   -------
   
   The existence of replace objects or commit grafts turns off reading or
  -writing to the commit-graph. See linkgit:git-commit-graph[1].
  +writing to the commit-graph, which can cause performance issues. See
  +linkgit:git-commit-graph[1].
   
   SEE ALSO
   --------

base-commit: 67ad42147a7acc2af6074753ebd03d904476118f
-- 
2.54.0.13.g9c7419e39f8


  parent reply	other threads:[~2026-05-07 18:21 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-05 20:45 [PATCH] doc: add caveat about turning off commit-graph kristofferhaugsbakk
2026-05-06 13:59 ` Derrick Stolee
2026-05-07 14:30   ` Kristoffer Haugsbakk
2026-05-07 18:03     ` Derrick Stolee
2026-05-07 18:20 ` kristofferhaugsbakk [this message]
2026-05-07 18:59   ` [PATCH v2] " Derrick Stolee
2026-05-07 19:42   ` [PATCH v3] " kristofferhaugsbakk
2026-05-07 19:56     ` Derrick Stolee
2026-05-07 21:14       ` Kristoffer Haugsbakk
2026-05-11  1:16         ` Junio C Hamano
2026-05-11  8:29           ` Oswald Buddenhagen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=V2_caveat_commit-graph.68b@msgid.xyz \
    --to=kristofferhaugsbakk@fastmail.com \
    --cc=code@khaugsbakk.name \
    --cc=git@vger.kernel.org \
    --cc=stolee@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.