From: khali@linux-fr.org (Jean Delvare)
To: lm-sensors@vger.kernel.org
Subject: [lm-sensors] [Patch] Fintek F75375S/SP chip driver
Date: Thu, 02 Nov 2006 08:17:31 +0000 [thread overview]
Message-ID: <VlDWEaSC.1162455451.6428440.khali@localhost> (raw)
Hi Riku,
On 10/31/2006, Riku Voipio wrote:
>last time I mailed this, I didn't get any feedback - Is this the
>wrong place to send drivers for chips? Also I can't seem to find a
>way to register to the wiki to update the devices entry..
It is the right place, unfortunately it seems that nobody had the
interest and time to reviewing your code, and I'm currently not able to
do so myself either.
As for the wiki, we had to disable anonymous changes to avoid being
spammed. If you intend to become a regular contributor to our project,
we can create a named account for you, just ask. Otherwise, just tell us
what change you would like to do on the wiki and we'll do it for you.
> Compared to the previous version posted here, changes are minimal.
> The driver is slightly more compact and fan is started at full speed
> by default.
This sounds like a bad idea. Loading the driver should not make any
change to the device configuration.
> I didn't bother with the libsensors stuff, since supposedly
> there is a generic sysfs-reading version coming out soon.
"Soon" might take several months. Please provide patches to sensors and
libsensors, so that your driver can receive proper testing in the
meantime. Take a look at the f71805f part for a not-too-heavy
macro-and-loop-based implementation.
Thanks,
--
Jean Delvare
next reply other threads:[~2006-11-02 8:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-02 8:17 Jean Delvare [this message]
-- strict thread matches above, loose matches on Subject: below --
2006-10-31 22:07 [lm-sensors] [Patch] Fintek F75375S/SP chip driver Riku Voipio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VlDWEaSC.1162455451.6428440.khali@localhost \
--to=khali@linux-fr.org \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.